Add detectBindingResources to service binding config #25341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quick resume of ServiceBinding through Quarkus
Quarkus generates ServiceBinding resources through dekorate and currently supports the
binding.operators.coreos.com/v1alpha1API (in opposition tooperators.coreos.com/v1beta1written in https://dekorate.io/docs/service-binding).Service Binding spec is released on version
servicebinding.io/v1beta1, which changes significantly theServiceBindingAPI (ex. workload replaces application).The Service Binding Operator implements both
binding.operators.coreos.com/v1alpha1andservicebinding.io/v1alpha3.This change
detectBindingResources: trueis needed on theServiceBindingresource withservicedescribed withkind: KafkaConnectioninstead ofresource: kafkaconnections. Same applies to service registry.Added documentation on Kafka guide for using RHOAS with Quarkus generated service binding.