Harmonize the usage of charset in the Content-Type headers for RESTEasy Reactive #25390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@FroMage @stuartwdouglas can I get a review of this please? Thanks |
FroMage
previously requested changes
May 10, 2022
|
|
||
| // TODO: does this need to be more complex? | ||
| private boolean isStringMediaType(MediaType mediaType) { | ||
| return mediaType.getType().equals("application") |
There was a problem hiding this comment.
All application/* types require a charset? That doesn't seem right.
There was a problem hiding this comment.
Which ones should in your opinion. JSON and XML?
There was a problem hiding this comment.
Updated to be much more strict
gastaldi
reviewed
May 16, 2022
...e/server/runtime/src/main/java/org/jboss/resteasy/reactive/server/core/EncodedMediaType.java
Outdated
Show resolved
Hide resolved
geoand
force-pushed
the
#25295
branch
2 times, most recently
from
de8ac98 to
49ec0e2
Compare
This comment has been minimized.
This comment has been minimized.
geoand
added
the
triage/waiting-for-ci
This comment has been minimized.
This comment has been minimized.
…sy Reactive The idea is that we know only append it for specific response media types. Before this change, the charset was added depending on how the return type of the Resource method Relates to: quarkusio#25295
quarkus-bot
bot
removed
the
triage/waiting-for-ci
|
I wonder if this is what's caused a Renarde test to fail when bumping from 2.9.0 to 2.9.1: |
|
The change should only affect the charset... |
|
I would have thought too, but given that a charset appeared… Lemme try to figure it out. |
|
Actually it shouldn't be that, because it works in 2.9.1 and 2.9.2 as well, but it's broken in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is that we know only append it for specific response media types.
Before this change, the charset was added depending on how the return type
of the Resource method
Relates to: #25295