Refactor docs for database dev services #25403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoand
changed the title
gsmet
requested changes
May 12, 2022
| quarkus.datasource.devservices.container-properties.TC_MY_CNF=testcontainers/mysql-conf | ||
| ---- | ||
|
|
||
| PostgreSQL docker images can be configured via docker command (see https://github.com/docker-library/docs/blob/master/postgres/README.md#database-configuration[the official docu]). |
There was a problem hiding this comment.
Suggested change
| PostgreSQL docker images can be configured via docker command (see https://github.com/docker-library/docs/blob/master/postgres/README.md#database-configuration[the official docu]). | |
| PostgreSQL Docker images can be configured via a Docker command (see https://github.com/docker-library/docs/blob/master/postgres/README.md#database-configuration[the official documentation]). |
There was a problem hiding this comment.
I took out the whole part. Will be added back during #25289
| ---- | ||
|
|
||
| PostgreSQL docker images can be configured via docker command (see https://github.com/docker-library/docs/blob/master/postgres/README.md#database-configuration[the official docu]). | ||
| For the PostgreSQL Dev Service the command can be set like this: |
There was a problem hiding this comment.
Suggested change
| For the PostgreSQL Dev Service the command can be set like this: | |
| For instance, a command could be set like this: |
There was a problem hiding this comment.
I took out the whole part. Will be added back during #25289
Comment on lines
81
to
76
| quarkus.datasource.devservices.container-properties.CMD=postgres -c wal_level=logical | ||
| ---- | ||
|
|
||
| This support is database specific and needs to be implemented in each dev service specifically. |
newur
force-pushed
the
add-datasource-dev-service-docu
branch
from
b5af980 to
e73631b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a separate PR from #25289