Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev services: MSSQL reactive client does not support JDBC url format #25487

Merged
merged 3 commits into from
May 24, 2022

Conversation

tsegismont
Copy link
Contributor

Fixes #25233

The "encrypt" property is not needed anyway, it is the default of both the JDBC and reactive clients.

https://docs.microsoft.com/en-us/sql/connect/jdbc/understanding-ssl-support?view=sql-server-ver15#remarks

@tsegismont
Copy link
Contributor Author

@cescoffier wdyt about backporting?

@tsegismont tsegismont requested review from gsmet and cescoffier May 12, 2022 09:11
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should rather generate two different URLs, one for JDBC and one for reactive.
If you do it in the classes like MSSQLDevServicesProcessor, you would have the url parameters map handy so you could filter them far more effectively.

Note that it is a proposal, maybe it's going to be too much maintenance for too little benefits, I don't know.
You could also make it optional i.e. if you push a specific reactive URL, you use it and if not you rely on your dark magic.
But I'm worried the dark magic will be brittle.

Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comments as Guillaume, but I think that except about encrypt it looks good.

This is simpler than transforming a JDBC url string.
@tsegismont
Copy link
Contributor Author

@gsmet I've updated the PR following your suggestions. It looks better indeed.

@cescoffier
Copy link
Member

I think it should be backported

@tsegismont
Copy link
Contributor Author

@cescoffier thank you for reviewing again. I'll wait for @gsmet 's approval and then create a PR for 2.8 branch.

@tsegismont
Copy link
Contributor Author

@gsmet anything else that needs to be addressed?

@cescoffier
Copy link
Member

@tsegismont just add the backport label, no need to create a separate PR (except if we @gsmet asks for it)

@gsmet
Copy link
Member

gsmet commented May 19, 2022

I'll have another look on Monday.

@tsegismont tsegismont requested a review from gsmet May 24, 2022 12:53
@gsmet gsmet merged commit b823cb9 into quarkusio:main May 24, 2022
@quarkus-bot quarkus-bot bot added this to the 2.10 - main milestone May 24, 2022
@tsegismont tsegismont deleted the issue_25233 branch May 24, 2022 17:01
@gsmet gsmet modified the milestones: 2.10 - main, 2.9.2.Final May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dev Services : MSSQL Connection Error 2.8.1.Final or 2.8.2.Final
3 participants