-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev services: MSSQL reactive client does not support JDBC url format #25487
Conversation
Fixes quarkusio#25233 The "encrypt" property is not needed anyway, it is the default of both the JDBC and reactive clients. https://docs.microsoft.com/en-us/sql/connect/jdbc/understanding-ssl-support?view=sql-server-ver15#remarks
@cescoffier wdyt about backporting? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should rather generate two different URLs, one for JDBC and one for reactive.
If you do it in the classes like MSSQLDevServicesProcessor
, you would have the url parameters map handy so you could filter them far more effectively.
Note that it is a proposal, maybe it's going to be too much maintenance for too little benefits, I don't know.
You could also make it optional i.e. if you push a specific reactive URL, you use it and if not you rely on your dark magic.
But I'm worried the dark magic will be brittle.
.../src/main/java/io/quarkus/reactive/mssql/client/deployment/ReactiveMSSQLClientProcessor.java
Outdated
Show resolved
Hide resolved
...io/quarkus/datasource/deployment/spi/DevServicesDatasourceConfigurationHandlerBuildItem.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comments as Guillaume, but I think that except about encrypt it looks good.
...io/quarkus/datasource/deployment/spi/DevServicesDatasourceConfigurationHandlerBuildItem.java
Outdated
Show resolved
Hide resolved
...io/quarkus/datasource/deployment/spi/DevServicesDatasourceConfigurationHandlerBuildItem.java
Outdated
Show resolved
Hide resolved
.../src/main/java/io/quarkus/reactive/mssql/client/deployment/ReactiveMSSQLClientProcessor.java
Outdated
Show resolved
Hide resolved
This is simpler than transforming a JDBC url string.
@gsmet I've updated the PR following your suggestions. It looks better indeed. |
I think it should be backported |
@cescoffier thank you for reviewing again. I'll wait for @gsmet 's approval and then create a PR for |
@gsmet anything else that needs to be addressed? |
@tsegismont just add the backport label, no need to create a separate PR (except if we @gsmet asks for it) |
I'll have another look on Monday. |
Fixes #25233
The "encrypt" property is not needed anyway, it is the default of both the JDBC and reactive clients.
https://docs.microsoft.com/en-us/sql/connect/jdbc/understanding-ssl-support?view=sql-server-ver15#remarks