Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinitialize com.sun.management.internal.PlatformMBeanProviderImpl #25598

Closed
wants to merge 1 commit into from

Conversation

zakkak
Copy link
Contributor

@zakkak zakkak commented May 16, 2022

Work around #25501 until
oracle/graal#4543 gets resolved

Fixes #25501

@zakkak zakkak requested review from gsmet and loicmathieu May 16, 2022 12:05
@quarkus-bot quarkus-bot bot added the area/grpc gRPC label May 16, 2022
@zakkak
Copy link
Contributor Author

zakkak commented May 16, 2022

@jiekang can you please have a look at this PR and verify that this reinitialization won't cause any JFR breakage? Thanks

Copy link
Contributor

@loicmathieu loicmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
Are you sure the issue is only for gRPC based application ? Shouldn't this be on core-deployment instead ?
I can try this branch tomorrow afternoon to confirm it on GCP services if you didn't already did it.

@jiekang
Copy link

jiekang commented May 16, 2022

@jiekang can you please have a look at this PR and verify that this reinitialization won't cause any JFR breakage? Thanks

@zhengyu123 ^ any chance you have cycles for this?

@zakkak
Copy link
Contributor Author

zakkak commented May 16, 2022

Are you sure the issue is only for gRPC based application ?

It's certainly not, but I don't really understand why it only pops up with gRPC.

Shouldn't this be on core-deployment instead ?

Not sure, I 'll leave that to the Quarkus team :)

I can try this branch tomorrow afternoon to confirm it on GCP services if you didn't already did it.

👍 I only tried it with the reproducer from #25501

@quarkus-bot

This comment has been minimized.

@geoand
Copy link
Contributor

geoand commented May 17, 2022

Shouldn't this be on core-deployment instead ?

Not sure, I 'll leave that to the Quarkus team :)

I think it should be part of the core

@zakkak zakkak force-pushed the workaround-graal-4543 branch from 8e0b108 to e56c29f Compare May 17, 2022 09:08
@zakkak zakkak force-pushed the workaround-graal-4543 branch from e56c29f to cbc41d4 Compare May 17, 2022 09:09
@zakkak
Copy link
Contributor Author

zakkak commented May 17, 2022

I think it should be part of the core

Done

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@loicmathieu
Copy link
Contributor

They fix it at Google library side, see GoogleCloudPlatform/native-image-support-java#395
If the issue occurs on other gRPC base extension it will not fix it for them as the Google native-image-support library is not integrated inside our gRPC support but inside the Google Services extension pack.

I hope they will do a release soon.

@zhengyu123
Copy link

@jiekang can you please have a look at this PR and verify that this reinitialization won't cause any JFR breakage? Thanks

@zhengyu123 ^ any chance you have cycles for this?

I don't see any problems.

-Zhengyu

@zakkak
Copy link
Contributor Author

zakkak commented May 17, 2022

If the issue occurs on other gRPC base extension it will not fix it for them as the Google native-image-support library is not integrated inside our gRPC support but inside the Google Services extension pack.

To my understanding the issue itself is caused by the Google native-image-support library. If you look at the patch what it does is to remove some registrations for reflection, as a result if other extensions don't do similar registrations things should be fine.

@loicmathieu
Copy link
Contributor

So maybe this fix is not needed anymore as the issue has been fixed on the upstream library ?
Or maybe we can keep it as a safety net in case other have done the same.

@quarkus-bot
Copy link

quarkus-bot bot commented May 17, 2022

Failing Jobs - Building cbc41d4

Status Name Step Failures Logs Raw logs
Gradle Tests - JDK 11 Windows Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 Windows #

- Failing: integration-tests/gradle 

📦 integration-tests/gradle

io.quarkus.gradle.devmode.QuarkusDevDependencyDevModeTest.main line 14 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference, java.util.concurrent.atomic.AtomicReferencejava.lang.String, java.lang.Stringboolean was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

@zakkak
Copy link
Contributor Author

zakkak commented May 17, 2022

So maybe this fix is not needed anymore as the issue has been fixed on the upstream library ?
Or maybe we can keep it as a safety net in case other have done the same.

I would prefer not getting this merged. If it turns out to be an actual issue for others as well we can reconsider. WDYT @geoand ?

@geoand
Copy link
Contributor

geoand commented May 17, 2022

Yeah, that makes sense to me

@zakkak zakkak closed this May 18, 2022
@quarkus-bot quarkus-bot bot added triage/invalid This doesn't seem right and removed triage/backport? labels May 18, 2022
loicmathieu added a commit to loicmathieu/google-cloud-services that referenced this pull request May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core area/grpc gRPC triage/invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ecosystem CI for Google Cloud Services fails with Quarkus main
5 participants