-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reinitialize com.sun.management.internal.PlatformMBeanProviderImpl #25598
Conversation
@jiekang can you please have a look at this PR and verify that this reinitialization won't cause any JFR breakage? Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
Are you sure the issue is only for gRPC based application ? Shouldn't this be on core-deployment instead ?
I can try this branch tomorrow afternoon to confirm it on GCP services if you didn't already did it.
@zhengyu123 ^ any chance you have cycles for this? |
It's certainly not, but I don't really understand why it only pops up with gRPC.
Not sure, I 'll leave that to the Quarkus team :)
👍 I only tried it with the reproducer from #25501 |
This comment has been minimized.
This comment has been minimized.
I think it should be part of the core |
8e0b108
to
e56c29f
Compare
Work around quarkusio#25501 until oracle/graal#4543 gets resolved
e56c29f
to
cbc41d4
Compare
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
They fix it at Google library side, see GoogleCloudPlatform/native-image-support-java#395 I hope they will do a release soon. |
I don't see any problems. -Zhengyu |
To my understanding the issue itself is caused by the Google native-image-support library. If you look at the patch what it does is to remove some registrations for reflection, as a result if other extensions don't do similar registrations things should be fine. |
So maybe this fix is not needed anymore as the issue has been fixed on the upstream library ? |
Failing Jobs - Building cbc41d4
Full information is available in the Build summary check run. Failures⚙️ Gradle Tests - JDK 11 Windows #- Failing: integration-tests/gradle
📦 integration-tests/gradle✖
|
I would prefer not getting this merged. If it turns out to be an actual issue for others as well we can reconsider. WDYT @geoand ? |
Yeah, that makes sense to me |
Work around #25501 until
oracle/graal#4543 gets resolved
Fixes #25501