Leverage delayed property in Gradle extension plugin #25631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/devtools
|
/cc @sebersole |
This comment has been minimized.
This comment has been minimized.
glefloch
force-pushed
the
fix/delayed-property-extension
branch
from
39ec8d0 to
65eba5d
Compare
sebersole
reviewed
May 17, 2022
| task.setClasspath(runtimeModuleClasspath); | ||
| }); | ||
| ExtensionDescriptorTask.class, quarkusExt); | ||
| extensionDescriptorTask.configure(task -> { |
There was a problem hiding this comment.
You could even consider moving this into the ExtensionDescriptorTask constructor.
glefloch
force-pushed
the
fix/delayed-property-extension
branch
from
65eba5d to
ad086f9
Compare
aloubyansky
approved these changes
May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #25615 but for the extension plugin. This introduce both :
Property/ListProperty