Provider tighter integration of Qute into RESTEasy Reactive #25709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
geoand
force-pushed
the
rr-qute-handler
branch
3 times, most recently
from
8d47675 to
26933d1
Compare
This comment has been minimized.
This comment has been minimized.
gastaldi
reviewed
May 22, 2022
| /** | ||
| * handlers are invoked after the handlers that run after the method invocation | ||
| */ | ||
| AFTER_METHOD_INVOKE_SECOND_ROUND, |
There was a problem hiding this comment.
How about naming it BEFORE_RESPONSE_CREATED?
There was a problem hiding this comment.
I could do that, but I think the current name (although bad) makes the intent more clear
|
@mkouba can you take a look at this one? Thanks |
mkouba
approved these changes
May 24, 2022
...time/src/main/java/io/quarkus/resteasy/reactive/qute/runtime/TemplateResponseUniHandler.java
Show resolved
Hide resolved
...time/src/main/java/io/quarkus/resteasy/reactive/qute/runtime/TemplateResponseUniHandler.java
Show resolved
Hide resolved
This change uses the ServerRestHandler mechanism instead of a response filter to convert a template into a response. This also paves the way to implement returning template responses as chunks (using Qute's createMulti)
mkouba
added
the
triage/waiting-for-ci
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change uses the ServerRestHandler mechanism instead of a response filter
to convert a template into a response.
This also paves the way to implement returning template responses
as chunks (using Qute's
createMulti)