Ensure that Vert.x's ConnectionBase#remoteAddress does not return null #25718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
The failures are definitely related to this PR. I'll have a look tomorrow |
This comment has been minimized.
This comment has been minimized.
This is done for the Amazon lambda stuff in order to ensure that tracing works properly. The remote address is currently set to the local Quarkus server, which seems to make most sense. Fixes: quarkusio#25708
|
@patriot1burke this should be ready for review |
patriot1burke
approved these changes
May 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done for the Amazon lambda stuff in order to ensure
that tracing works properly.
The remote address is currently set to the local Quarkus server,
which seems to make most sense.
Fixes: #25708