Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension excluded resources in quarkus-extension.properties #25802

Merged

Conversation

aloubyansky
Copy link
Member

Fix #25655

Adds a possibility to configure removed resources [1] in the extension's META-INF/quarkus-extension.properties.

NOTE: another change is that it will also create RemovedResourceBuildItem for each configured removed resource, so it is also removed from the packaged app. Otherwise, the resources are only removed from the classloader for the build and dev mode but will still be loadable in prod mode.

FYI @stuartwdouglas

[1] https://quarkus.io/guides/class-loading-reference#quarkus-class-loading-configuration-class-loading-config_quarkus.class-loading.removed-resources-removed-resources

@quarkus-bot quarkus-bot bot added area/core area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven labels May 26, 2022
@aloubyansky aloubyansky force-pushed the extension-excluded-resources branch from 498053a to 2bb3362 Compare May 26, 2022 06:43
@aloubyansky aloubyansky force-pushed the extension-excluded-resources branch from 2bb3362 to f8eeaa1 Compare May 26, 2022 06:50
<deployment>\${project.groupId}:\${project.artifactId}-deployment:\${project.version}</deployment>
<removedResources>
<org.acme:acme-resources>META-INF/a</org.acme:acme-resources>
</removedResources>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^ is how it can be configured in an extension.

@xstefank
Copy link
Member

xstefank commented May 30, 2022

Thanks @aloubyansky. This PR provides means to fix the LRA issue with resteasy-reactive client.

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@aloubyansky aloubyansky merged commit 310485e into quarkusio:main May 31, 2022
@quarkus-bot quarkus-bot bot added this to the 2.10 - main milestone May 31, 2022
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label May 31, 2022
@aloubyansky
Copy link
Member Author

@glefloch we'd need an equivalent config option in the Gradle extension plugin. Would you like to add it?

@glefloch
Copy link
Member

Sure, I can work on it.

@aloubyansky
Copy link
Member Author

Thanks @glefloch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "excluded-resources" configuration to the ApplicationModel
4 participants