Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused config class #25853

Merged
merged 1 commit into from
May 31, 2022
Merged

Remove unused config class #25853

merged 1 commit into from
May 31, 2022

Conversation

geoand
Copy link
Contributor

@geoand geoand commented May 30, 2022

No description provided.

@geoand geoand marked this pull request as ready for review May 30, 2022 07:29
gsmet
gsmet reviewed May 30, 2022
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just asking but it's not considered API or something that users could use to cache a slow config source?
Maybe it should live in SmallRye Config though in this case.

@geoand
Copy link
Contributor Author

geoand commented May 30, 2022

It's part of the runtime package and it's never been part of the documentation, so I would say it should be pretty safe to remove

@quarkus-bot

This comment has been minimized.

Sign in to view
@gastaldi gastaldi requested a review from dmlloyd May 31, 2022 01:42
@quarkus-bot
Copy link

quarkus-bot bot commented May 31, 2022

Failing Jobs - Building c3b4ac3

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✖ JVM Tests - JDK 17 Build Failures Logs Raw logs

Failures

⚙️ JVM Tests - JDK 17 #

- Failing: integration-tests/elasticsearch-rest-client

📦 integration-tests/elasticsearch-rest-client

✖ Failed to execute goal io.fabric8:docker-maven-plugin:0.39.1:start (docker-start) on project quarkus-integration-test-elasticsearch-rest-client: I/O Error

@geoand geoand merged commit 6cf2297 into quarkusio:main May 31, 2022
@quarkus-bot quarkus-bot bot added this to the 2.10 - main milestone May 31, 2022
@geoand geoand deleted the config-removal branch May 31, 2022 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet left review comments

@gastaldi gastaldi gastaldi approved these changes

@dmlloyd dmlloyd dmlloyd approved these changes

Assignees
No one assigned
Labels
area/config area/core
Projects
None yet
Milestone
2.10.0.CR1
Development

Successfully merging this pull request may close these issues.
4 participants
@geoand @gastaldi @dmlloyd @gsmet