Option to enable workspace discovery in NORMAL mode #25933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/core
area/devtools
|
This is related to #9818 |
|
Thanks @aloubyansky ! I agree about documenting it in Jib |
|
I think this is fine as it's a simple boolean. |
geoand
approved these changes
Jun 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workspace discovery is enabled by default only in DEV and TEST modes but not NORMAL. This PR introduces a way to enable workspace discovery in NORMAL mode by setting
quarkus.bootstrap.workspace-discoverysystem property or in the POM (not application config though).@geoand I think a place to document it would be in the JIB container image guide. It's not really useful for anything else, at the moment.
@glefloch would DSL be preferred for this kind of config? For now I just added a system and a project property support just to have something in Gradle but we could improve it.