Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Websockets logging during native image build #25936

Merged
merged 1 commit into from
Jun 3, 2022

Conversation

gastaldi
Copy link
Contributor

@gastaldi gastaldi commented Jun 2, 2022

This gets rid of the following messages when building the native image:

16:32:37,255 INFO  [io.und.websockets] UT026004: Adding annotated client endpoint class io.quarkus.it.websocket.CodingClient
16:32:37,260 INFO  [io.und.websockets] UT026003: Adding annotated server endpoint class io.quarkus.it.websocket.RecodingSocket for path /recoder
16:32:37,260 INFO  [io.und.websockets] UT026003: Adding annotated server endpoint class io.quarkus.it.websocket.EchoSocket for path /echo
16:32:37,260 INFO  [io.und.websockets] UT026003: Adding annotated server endpoint class io.quarkus.it.websocket.WebSocketOpenEndpoint for path /wsopen
16:32:37,367 INFO  [io.und.websockets] UT026005: Adding programmatic server endpoint class io.quarkus.it.websocket.AddWebSocketHandler$WebSocketEndpoint for path /added-dynamic

This gets rid of the following messages when building the native image:

```
16:32:37,255 INFO  [io.und.websockets] UT026004: Adding annotated client endpoint class io.quarkus.it.websocket.CodingClient
16:32:37,260 INFO  [io.und.websockets] UT026003: Adding annotated server endpoint class io.quarkus.it.websocket.RecodingSocket for path /recoder
16:32:37,260 INFO  [io.und.websockets] UT026003: Adding annotated server endpoint class io.quarkus.it.websocket.EchoSocket for path /echo
16:32:37,260 INFO  [io.und.websockets] UT026003: Adding annotated server endpoint class io.quarkus.it.websocket.WebSocketOpenEndpoint for path /wsopen
16:32:37,367 INFO  [io.und.websockets] UT026005: Adding programmatic server endpoint class io.quarkus.it.websocket.AddWebSocketHandler$WebSocketEndpoint for path /added-dynamic
```
@gastaldi gastaldi requested a review from gsmet June 2, 2022 19:38
@gastaldi gastaldi requested a review from geoand June 2, 2022 19:38
/**
* Disables logging during the analysis phase
*/
@AutomaticFeature
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just keep in mind for the (not too distant) future, that GraalVM won't be doing classpath scanning to find these, so we'll have to add a build item and explicitly register them on the command line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know, thanks for the info! 👍🏻

@gastaldi gastaldi merged commit 338fe10 into quarkusio:main Jun 3, 2022
@quarkus-bot quarkus-bot bot added this to the 2.10 - main milestone Jun 3, 2022
@gastaldi gastaldi deleted the disable_websocket_logging branch June 3, 2022 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants