Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Reactive Rest Client support of dynamic query parameters #26191

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

michalvavrik
Copy link
Member

Documents: 24783

Reactive Rest Client supports sending of query parameters passed as a Map, however I can't see this in documentation. There should be at least one reference to this feature.

@michalvavrik
Copy link
Member Author

@geoand WDYT?

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

I added a couple comments

@michalvavrik michalvavrik force-pushed the feature/document-rest-query-map branch from a6fc895 to 3e583d5 Compare June 16, 2022 16:32
@michalvavrik
Copy link
Member Author

Thank you for the review.

@michalvavrik michalvavrik requested a review from geoand June 16, 2022 16:37
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@geoand geoand added triage/waiting-for-ci Ready to merge when CI successfully finishes triage/backport? labels Jun 16, 2022
Documents: [24783](quarkusio#24783)

Reactive Rest Client sending query paramters passed as a `Map`, however I can't see this in documentation. There should be at least reference to this feature.
@michalvavrik michalvavrik force-pushed the feature/document-rest-query-map branch from 3e583d5 to 95157c5 Compare June 16, 2022 17:13
@geoand geoand merged commit 33486ec into quarkusio:main Jun 16, 2022
@quarkus-bot quarkus-bot bot added this to the 2.11 - main milestone Jun 16, 2022
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 16, 2022
@michalvavrik michalvavrik deleted the feature/document-rest-query-map branch June 16, 2022 19:38
@gsmet gsmet modified the milestones: 2.11 - main, 2.10.1.Final Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants