Upgrade to JDK 19 for JDK early-access build

[yrodiere]

Also switch to oracle/setup-java by default, because that's the easiest
way to retrieve the latest binaries for EA releases.
It only supports Oracle builds though, so we keep actions/setup-java for
people who need to launch this workflow manually.

[yrodiere]

Note it's about time, since EA builds of JDK 20 are starting to get published... :) (JDK 19 is still EA at the moment, though)

[gsmet]

I already have a branch with this and @famod has a branch too but it's more complicated than that.

[gsmet]

See https://github.com/gsmet/quarkus/commits/19-ea .

[yrodiere]

I'm sure upgrading Quarkus will require more work, but there's no point keeping a workflow with JDK 18 EA running. Let's just merge this and disable the workflow until someone can get it to work?

[famod]

The strategy up to now was to aggressively disable the bits that are failing (if there is no upstream fix yet), but I haven't found the time to finish this for 19-ea.
So we should disable those invoker tests on Java 19+ via Maven profiles.

[famod]

Btw, a general flag to disable Gradle and/or Kotlin bits might come in handy as those never seem to work on EAs (maybe shortly before GA, if you're lucky).
Also, when building with quickly, Gradle modules are the top time consumers.

[famod]

FTR: #24789

[famod]

Having said all that, I think this change makes sense for now but maybe we should also remove the schedule until someone found the time to drive it home (but retain the ability to run manually).

[yrodiere]

Regarding Gradle, you should definitely look into toolchains. We're using them in Hibernate ORM / Reactive and have been upgrading to newer JDKs (including 19) without any problem for a while. It requires that you install both JDK 17 (for Gradle) and 19 (for your build/tests), though. See:

• https://docs.gradle.org/current/userguide/toolchains.html
• https://github.com/hibernate/hibernate-reactive/blob/main/.github/workflows/build.yml#L170-L192

And ideally you'd use a different JDK to build the main code and to build/run the tests, but that's more complicated, so I wouldn't recommend it as a first step. See:

• https://github.com/hibernate/hibernate-reactive/blob/main/settings.gradle#L18-L51
• https://github.com/hibernate/hibernate-reactive/blob/main/build.gradle#L160-L221

[famod]

IIRC, @glefloch had a look at toolchains quite some time ago. Maybe we should revisit.

[glefloch]

Yes I think we should otherwise we will be in the same situation for every new Java release

[famod]

Let's just merge this and improve from there.