Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenTelemetry: NPE in HttpInstrumenterVertxTracer.RouteGetter when request got cancelled #26779

Merged
merged 1 commit into from
Jul 25, 2022
Merged

OpenTelemetry: NPE in HttpInstrumenterVertxTracer.RouteGetter when request got cancelled #26779

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions ...main/java/io/quarkus/opentelemetry/runtime/tracing/vertx/HttpInstrumenterVertxTracer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import static io.opentelemetry.semconv.trace.attributes.SemanticAttributes.HTTP_CLIENT_IP;
import static io.quarkus.opentelemetry.runtime.OpenTelemetryConfig.INSTRUMENTATION_NAME;

import java.util.Collections;
import java.util.List;
import java.util.function.BiConsumer;

Expand Down Expand Up @@ -151,7 +152,7 @@ public String get(final io.opentelemetry.context.Context context, final HttpRequ
return route;
}

if (HttpResponseStatus.NOT_FOUND.code() == response.statusCode()) {
if (response != null && HttpResponseStatus.NOT_FOUND.code() == response.statusCode()) {
return "/*";
}

Expand Down Expand Up @@ -231,12 +232,12 @@ public Long requestContentLengthUncompressed(final HttpRequest request, final Ht

@Override
public Integer statusCode(final HttpRequest request, final HttpResponse response) {
return response.statusCode();
return response != null ? response.statusCode() : null;
}

@Override
public Long responseContentLength(final HttpRequest request, final HttpResponse response) {
return getContentLength(response.headers());
return response != null ? getContentLength(response.headers()) : null;
}

@Override
Expand All @@ -246,7 +247,7 @@ public Long responseContentLengthUncompressed(final HttpRequest request, final H

@Override
public List<String> responseHeader(final HttpRequest request, final HttpResponse response, final String name) {
return response.headers().getAll(name);
return response != null ? response.headers().getAll(name) : Collections.emptyList();
}

private static Long getContentLength(final MultiMap headers) {
Expand Down