-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add access log handler to the main router if non-app root-path is different from root-path #26783
Conversation
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
|
@ebullient could you have a look at this one? I think it makes sense but would prefer you having a look. |
...nsions/vertx-http/runtime/src/main/java/io/quarkus/vertx/http/runtime/VertxHttpRecorder.java
Show resolved
Hide resolved
…ferent from root-path
d4abc33
to
767eeda
Compare
@ebullient @gsmet I did this over a morning coffee to have fresh eyes. So original was wrong IMO because the root router included in case both root path and non-root path was specified also 404s logs of any accesses, which is not something we have now and probably don't want. So I rather changed it to pull created framework router into the recorder and just add the handler to the framework router if it's not mounted under the root path router. Here I did some more extensive testing - https://gist.github.com/xstefank/036ad52c5e40644ad1228915f22f5369 which shows the behavior of this PR, which I think is correct. |
Failing Jobs - Building 767eeda
Full information is available in the Build summary check run. Failures⚙️ Gradle Tests - JDK 11 #- Failing: integration-tests/gradle
📦 integration-tests/gradle✖
✖
⚙️ JVM Tests - JDK 11 Windows #- Failing: extensions/vertx-http/deployment
! Skipped: extensions/agroal/deployment extensions/amazon-lambda-http/deployment extensions/amazon-lambda-rest/deployment and 309 more 📦 extensions/vertx-http/deployment✖
|
Fixes #26782
I wanted to write a test but in test mode the framework router is not created and everything is under HTTP root router so I think that adding an if case for test mode would be overkill.