Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make org.graalvm.regex:regex parent first #27090

Merged
merged 1 commit into from
Aug 3, 2022
Merged

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Aug 2, 2022

Fixes #27085

@rvansa can you try if this PR fixes your issue?
Also, if there are just a couple of artifacts that need syncing with the GraalVM version, maybe we could add them to the BOM if it makes things significantly easier. Let me know if you have a list. (I'm not really inclined to add 20 of them for such a use case but if it's 2 or 3, that could work)

@rvansa
Copy link
Contributor

rvansa commented Aug 2, 2022

Building Quarkus... thanks! I guess that the difference in behaviour comes from adding Truffle to those parent-first loaders - I've found that the code checks where is TruffleLanguage loaded from and ignores unsuitable loaders...

@rvansa
Copy link
Contributor

rvansa commented Aug 2, 2022

For some reason I can't build the branch with ./mvnw install -DskipTests - it fails with

Failed to execute goal io.quarkus:quarkus-maven-plugin:999-SNAPSHOT:build (default) on project quarkus-cli: Failed to build quarkus application: java.lang.ClassNotFoundException: io.quarkus.deployment.TestConfig

@gsmet
Copy link
Member Author

gsmet commented Aug 2, 2022

Try ./mvnw -Dquickly but I'm not sure it will solve anything. It looks a bit weird. Maybe do a proper clean first and remove the io.quarkus artifacts from your .m2?

@quarkus-bot
Copy link

quarkus-bot bot commented Aug 2, 2022

Failing Jobs - Building 758aee5

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 11 Windows Build Failures Logs Raw logs
✔️ JVM Tests - JDK 17
✔️ JVM Tests - JDK 18

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 Windows #

- Failing: extensions/quartz/deployment 
! Skipped: integration-tests/quartz 

📦 extensions/quartz/deployment

io.quarkus.quartz.test.FireTimeTest.testExecution line 39 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

@rvansa
Copy link
Contributor

rvansa commented Aug 3, 2022

@gsmet OK, build with -Dquickly worked and now I confirm that this fixes my issue. Thanks!

@gsmet
Copy link
Member Author

gsmet commented Aug 3, 2022

Thanks for testing, I will backport it to the next micro.

@gsmet gsmet requested a review from geoand August 3, 2022 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression with upgrade 2.9.2 -> 2.11.1 in app using GraalVM Javascript interpreter
3 participants