Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Keycloak version to 19.0.1 #27387

Merged
merged 1 commit into from
Aug 23, 2022
Merged

Conversation

sberyozkin
Copy link
Member

@sberyozkin sberyozkin commented Aug 19, 2022

I've spent nearly all day on this PR today as the new storage (Map based by default AFAIK) seems to have some clean up issues at the host and Dev Services based tests have been failing randomly (I've captured the same tests passing and then failing), and also the start time has increased, but then I've remembered that Pedro has advised to try --storage=chm - it stabilized it and the startup time is at least no worse compared to 18.0.2 on my old laptop but will likely be even better on newer laptops.
Also integration-tests/oidc-client-reactive which starts Dev Services for KC has a redundant profile.
I'm still seeing side-effects with 2 quickstarts but it looks like they are more related to the fact they use the realms created by very old Keycloak - I'll try to finalize it - but this PR itself should be ready for review.

@sberyozkin sberyozkin requested a review from pedroigor August 19, 2022 17:04
@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/oidc labels Aug 19, 2022
@sberyozkin sberyozkin requested a review from gsmet August 19, 2022 17:04
@quarkus-bot

This comment has been minimized.

@sberyozkin
Copy link
Member Author

quarkusio/quarkus-quickstarts#1159 fixes the quickstart issues, but this PR needs to be merged first

@quarkus-bot
Copy link

quarkus-bot bot commented Aug 22, 2022

Failing Jobs - Building 517c971

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 11 Windows Build Failures Logs Raw logs
✔️ JVM Tests - JDK 17
JVM Tests - JDK 18 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 Windows #

- Failing: extensions/grpc/deployment 
! Skipped: extensions/opentelemetry/opentelemetry-exporter-jaeger/deployment extensions/opentelemetry/opentelemetry-exporter-otlp/deployment extensions/opentelemetry/opentelemetry/deployment and 20 more

📦 extensions/grpc/deployment

io.quarkus.grpc.server.devmode.GrpcDevModeTest.testEchoStreamReload - More details - Source on GitHub

java.util.concurrent.RejectedExecutionException
	at org.jboss.threads.RejectingExecutor.execute(RejectingExecutor.java:38)
	at org.jboss.threads.EnhancedQueueExecutor.rejectShutdown(EnhancedQueueExecutor.java:2076)

⚙️ JVM Tests - JDK 18 #

- Failing: integration-tests/micrometer-prometheus 

📦 integration-tests/micrometer-prometheus

io.quarkus.it.micrometer.prometheus.ClientRequestTest.testClientRequests line 36 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Response body doesn't match expectation.

Copy link
Contributor

@pedroigor pedroigor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sberyozkin FYI, sessions do not expire after server restart if you are using storage=chm. That is because they are stored in the filesystem.

Not sure if it might impact tests that expect otherwise.

@sberyozkin
Copy link
Member Author

Hi @pedroigor I thought I left a comment here but looks like I lost it, yeah, I just said I'd check it out with devservices - it has no side-effects, as even if we restart, it is a new container start, so for example, I logged in as admin:admin and then stopped Quarkus without logging out, and then returned to Dev UI and got a new authentication challenge. I guess it is more related to the case where Keycloak is started from the cmd with kc.sh which is not the case with the devservices.

So I'll go ahead and merge, thanks

@sberyozkin sberyozkin merged commit e85d92a into quarkusio:main Aug 23, 2022
@quarkus-bot quarkus-bot bot added this to the 2.13 - main milestone Aug 23, 2022
@sberyozkin sberyozkin deleted the keycloak_19.0.1 branch August 23, 2022 11:43
@rsvoboda
Copy link
Member

There are new failures in security related QS, see https://github.com/quarkusio/quarkus-quickstarts/actions/workflows/native-build-development.yml
These failures are related to this change, when I used quarkus main 52379a5ce2e7d61447d96f7cb9f9c133822788b6 (the one before the merge) QS was passing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/oidc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants