-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Keycloak version to 19.0.1 #27387
Conversation
66e7a6f
to
190cf5f
Compare
This comment has been minimized.
This comment has been minimized.
quarkusio/quarkus-quickstarts#1159 fixes the quickstart issues, but this PR needs to be merged first |
190cf5f
to
517c971
Compare
Failing Jobs - Building 517c971
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 11 Windows #- Failing: extensions/grpc/deployment
! Skipped: extensions/opentelemetry/opentelemetry-exporter-jaeger/deployment extensions/opentelemetry/opentelemetry-exporter-otlp/deployment extensions/opentelemetry/opentelemetry/deployment and 20 more 📦 extensions/grpc/deployment✖
⚙️ JVM Tests - JDK 18 #- Failing: integration-tests/micrometer-prometheus
📦 integration-tests/micrometer-prometheus✖
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sberyozkin FYI, sessions do not expire after server restart if you are using storage=chm
. That is because they are stored in the filesystem.
Not sure if it might impact tests that expect otherwise.
Hi @pedroigor I thought I left a comment here but looks like I lost it, yeah, I just said I'd check it out with devservices - it has no side-effects, as even if we restart, it is a new container start, so for example, I logged in as So I'll go ahead and merge, thanks |
There are new failures in security related QS, see https://github.com/quarkusio/quarkus-quickstarts/actions/workflows/native-build-development.yml |
I've spent nearly all day on this PR today as the new storage (Map based by default AFAIK) seems to have some clean up issues at the host and Dev Services based tests have been failing randomly (I've captured the same tests passing and then failing), and also the start time has increased, but then I've remembered that Pedro has advised to try
--storage=chm
- it stabilized it and the startup time is at least no worse compared to18.0.2
on my old laptop but will likely be even better on newer laptops.Also
integration-tests/oidc-client-reactive
which starts Dev Services for KC has a redundant profile.I'm still seeing side-effects with 2 quickstarts but it looks like they are more related to the fact they use the realms created by very old Keycloak - I'll try to finalize it - but this PR itself should be ready for review.