-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix service binding for SqlServer and Oracle #27467
Fix service binding for SqlServer and Oracle #27467
Conversation
8ad50b1
to
9743d7e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@gsmet does the format also look good to you? |
Failing Jobs - Building 9743d7e
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 11 #- Failing: extensions/smallrye-reactive-messaging-kafka/deployment
! Skipped: integration-tests/kafka-oauth-keycloak integration-tests/kafka-sasl-elytron integration-tests/kubernetes/quarkus-standard-way-kafka and 3 more 📦 extensions/smallrye-reactive-messaging-kafka/deployment✖
|
@@ -13,6 +13,6 @@ public class MsSQLServiceBindingConverter implements ServiceBindingConverter { | |||
@Override | |||
public Optional<ServiceBindingConfigSource> convert(List<ServiceBinding> serviceBindings) { | |||
return ServiceBinding.singleMatchingByType("sqlserver", serviceBindings) | |||
.map(new DatasourceServiceBindingConfigSourceFactory.Jdbc()); | |||
.map(new DatasourceServiceBindingConfigSourceFactory.Jdbc("jdbc:%s://%s%s;databaseName=%s")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not related to your patch but this is really brittle and close to unreadable. But let's not slow down your patch because of that as it's preexisting.
I would rather have to implement a method that takes proper parameters with names.
fixes #27461
kubernetes-service-binding
extension.jdbc-url
to allow user to customize connection url for service binding. This is similar to what spring-service-binding supports.