Bump default Kafka dev service image to redpanda v22.1.7 #27617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cescoffier
approved these changes
Aug 31, 2022
This comment has been minimized.
This comment has been minimized.
ozangunalp
added
the
triage/waiting-for-ci
|
Not sure the test failures are related, but I would be cautious about merging with these failures |
|
@geoand yes test failures are related. They pass with redpanda v21.11.15 but fail with v22.x. |
geoand
removed
the
triage/waiting-for-ci
ozangunalp
force-pushed
the
redpanda_version_bump
branch
from
f440310 to
9b53e29
Compare
cescoffier
approved these changes
Aug 31, 2022
| @@ -57,6 +57,7 @@ protected void containerIsStarting(InspectContainerResponse containerInfo, boole | |||
| command += "--memory 1G --overprovisioned --reserve-memory 0M "; | |||
| command += String.format("--kafka-addr %s ", getKafkaAddresses()); | |||
| command += String.format("--advertise-kafka-addr %s ", getKafkaAdvertisedAddresses()); | |||
| command += "--set redpanda.auto_create_topics_enabled=true "; | |||
There was a problem hiding this comment.
Seriously! Wow... that's a big change of behavior!
There was a problem hiding this comment.
I edited the description because I couldn't make our tests work with v22.2.2. I get NotLeaderOrFollowerException from record send. I suspect producer metadata are not in sync after topic creation.
ozangunalp
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27352