Add kotlin formatting plugin #27673
Merged
Add kotlin formatting plugin #27673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/dependencies
This comment has been minimized.
This comment has been minimized.
quarkus-bot
bot
added
the
area/devtools
This comment has been minimized.
This comment has been minimized.
geoand
reviewed
Sep 2, 2022
Comment on lines
+778
to
+819
| <profile> | ||
| <id>format-kotlin</id> | ||
| <activation> | ||
| <activeByDefault>true</activeByDefault> | ||
| <property> | ||
| <name>!no-format</name> | ||
| </property> | ||
| <file> | ||
| <exists>src/main/kotlin</exists> | ||
| </file> | ||
| </activation> | ||
| <build> | ||
| <plugins> | ||
| <plugin> | ||
| <groupId>com.diffplug.spotless</groupId> | ||
| <artifactId>spotless-maven-plugin</artifactId> | ||
| <version>2.25.0</version> | ||
| <executions> | ||
| <execution> | ||
| <id>format-kotlin</id> | ||
| <phase>process-sources</phase> | ||
| <goals> | ||
| <goal>apply</goal> | ||
| </goals> | ||
| </execution> | ||
| </executions> | ||
|
|
||
| <configuration> | ||
| <kotlin> | ||
| <!-- | ||
| <ktfmt> | ||
| <style>DEFAULT</style> <!– optional, other options are DEFAULT, DROPBOX, GOOGLE and KOTLINLANG –> | ||
| </ktfmt> | ||
| --> | ||
| <ktlint/> | ||
|
|
||
| </kotlin> | ||
| </configuration> | ||
| </plugin> | ||
| </plugins> | ||
| </build> | ||
| </profile> |
There was a problem hiding this comment.
Do we really need a different profile? Would it not be better to use the existing profiles?
There was a problem hiding this comment.
I'm ok combining them but this one also looks for the existence of kotlin sources to activate. So it's not trying to do work most of the time. It might be a microoptimization but it made sense at the time. @gsmet?
Failing Jobs - Building 5c8c077
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 17 #- Failing: extensions/smallrye-reactive-messaging-kafka/deployment
! Skipped: integration-tests/kafka-oauth-keycloak integration-tests/kafka-sasl-elytron integration-tests/kubernetes/quarkus-standard-way-kafka and 3 more📦 extensions/smallrye-reactive-messaging-kafka/deployment✖ |
|
The failures look unrelated at this point. What do we think about this one? |
|
Yeah, it's a flaky test |
geoand
approved these changes
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this change will cause the kotlin sources to be formatted and cleaned up the same way the java sources are.