Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix streaming of JSON strings in RESTEasy Reactive #27719

Merged
merged 1 commit into from
Sep 5, 2022

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Sep 5, 2022

Fixes: #18043

P.S. I am definitely not proud of how this is fixed, but we don't have many options given how mismatched the MessageBodyWriter API is with streaming results. This way also avoid trying to manually escape characters which was attempted in #18401

@quarkus-bot quarkus-bot bot added the area/rest label Sep 5, 2022
@geoand geoand requested a review from Sgitario September 5, 2022 09:02
@geoand geoand changed the title Fix streaming of json strings in RESTEasy Reactive Fix streaming of JSON strings in RESTEasy Reactive Sep 5, 2022
@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 5, 2022
@quarkus-bot

This comment has been minimized.

@geoand
Copy link
Contributor Author

geoand commented Sep 5, 2022

Test failures are certainly related

@geoand
Copy link
Contributor Author

geoand commented Sep 5, 2022

Fixed

@geoand
Copy link
Contributor Author

geoand commented Sep 5, 2022

I am actually removing the backport labels and marking this as a breaking change because it is possible that some code depends on the previous (wrong) behavior

@gastaldi gastaldi merged commit b281bad into quarkusio:main Sep 5, 2022
@gastaldi gastaldi deleted the #18043 branch September 5, 2022 15:46
@quarkus-bot quarkus-bot bot added this to the 2.13 - main milestone Sep 5, 2022
@quarkus-bot quarkus-bot bot added kind/bugfix and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resteasy-reactive produces invalid json for Multi
3 participants