Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to JBoss Threads 3.4.3.Final and silence JBoss Threads version printing via system property #27780

Merged
merged 1 commit into from
Sep 8, 2022

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Sep 7, 2022

In some cases (typically Quarkus main tests), it is extremely hard to avoid printing the JBoss Threads version. Thus why we introduced a system property to disable version printing in JBoss Threads.

From:

[INFO] Running io.quarkiverse.githubaction.it.SimpleActionTest
2022-09-08 10:13:54,491 INFO  [org.jbo.threads] (main) JBoss Threads version 3.4.2.Final
2022-09-08 10:13:55,310 INFO  [org.jbo.threads] (main) JBoss Threads version 3.4.2.Final
SimpleAction - Test output
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.929 s - in io.quarkiverse.githubaction.it.SimpleActionTest

we now have:

[INFO] Running io.quarkiverse.githubaction.it.SimpleActionTest
SimpleAction - Test output
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.856 s - in io.quarkiverse.githubaction.it.SimpleActionTest

Fixes #24283

In some cases (typically Quarkus main tests), it is extremely hard to
avoir printing the JBoss Threads version. Thus why we introduced a
system property to disable version printing in JBoss Threads.
@gsmet gsmet added this to the 2.13 - main milestone Sep 7, 2022
@gsmet gsmet marked this pull request as draft September 7, 2022 11:19
@gsmet gsmet marked this pull request as ready for review September 8, 2022 08:14
@gsmet gsmet requested a review from geoand September 8, 2022 08:14
@gsmet gsmet changed the title Prepare for silencing JBoss Threads version via system property Upgrade to JBoss Threads 3.4.3.Final and silence JBoss Threads version printing via system property Sep 8, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Sep 8, 2022

Failing Jobs - Building 73ff828

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
JVM Tests - JDK 17 Build Failures Logs Raw logs
✔️ JVM Tests - JDK 18

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 17 #

- Failing: integration-tests/oidc-token-propagation-reactive 

📦 integration-tests/oidc-token-propagation-reactive

io.quarkus.it.keycloak.OidcTokenReactivePropagationTest.testGetUserNameWithAccessTokenPropagation line 22 - More details - Source on GitHub

com.gargoylesoftware.htmlunit.FailingHttpStatusCodeException: 401 Unauthorized for http://localhost:8081/frontend/access-token-propagation
	at com.gargoylesoftware.htmlunit.WebClient.throwFailingHttpStatusCodeExceptionIfNecessary(WebClient.java:701)
	at com.gargoylesoftware.htmlunit.WebClient.getPage(WebClient.java:461)

io.quarkus.it.keycloak.OidcTokenReactivePropagationTest.testNoToken line 43 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <302> but was <401>.

@gsmet
Copy link
Member Author

gsmet commented Sep 8, 2022

@sberyozkin could you have a look at the failing tests above? Flakiness on security-related tests makes me extremely nervous.

@gsmet gsmet merged commit fffe25b into quarkusio:main Sep 8, 2022
@gsmet gsmet modified the milestones: 2.13 - main, 2.12.2.Final Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JBoss Threads version logging in tests
2 participants