Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent NPE in setAllHeaders #28935

Merged
merged 1 commit into from
Oct 31, 2022
Merged

Prevent NPE in setAllHeaders #28935

merged 1 commit into from
Oct 31, 2022

Conversation

Sgitario
Copy link
Contributor

I didn't add any test to cover this change because it's easier to fix than to replicate the conditions to reproduce it in either the extension or an integration test.
Still, let me know if you want it to cover it and maybe I can add wiremock in the integration-tests/rest-client-reactive.
Fix #28922

I didn't add any test to cover this change because it's easier to fix than to replicate the conditions to reproduce it in either the extension or an integration test than expected taking into account we have a reproducer.
Still let me know if you want it to cover it and maybe I can add wiremock in the integration-tests/rest-client-reactive. 
Fix quarkusio#28922
@Sgitario Sgitario requested a review from geoand October 31, 2022 06:27
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can live without a test for this change :)

@geoand geoand added triage/backport? triage/waiting-for-ci Ready to merge when CI successfully finishes labels Oct 31, 2022
@geoand geoand changed the title Prevent null pointer in setAllHeaders Prevent NPE in setAllHeaders Oct 31, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 31, 2022

Failing Jobs - Building 1d074d6

Status Name Step Failures Logs Raw logs
✔️ Gradle Tests - JDK 11
Gradle Tests - JDK 11 Windows Build Failures Logs Raw logs
JVM Tests - JDK 11 Build Failures Logs Raw logs
✔️ JVM Tests - JDK 17
✔️ JVM Tests - JDK 17 MacOS M1
✔️ JVM Tests - JDK 18

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 Windows #

- Failing: integration-tests/gradle 

📦 integration-tests/gradle

io.quarkus.gradle.devmode.BasicJavaLibraryModuleDevModeTest.main line 23 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference was not fulfilled within 3 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

⚙️ JVM Tests - JDK 11 #

- Failing: integration-tests/opentelemetry-reactive-messaging 

📦 integration-tests/opentelemetry-reactive-messaging

io.quarkus.it.opentelemetry.OpenTelemetryTestCase.testProcessorTracing line 95 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.it.opentelemetry.OpenTelemetryTestCase was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

@geoand geoand merged commit d4d05b5 into quarkusio:main Oct 31, 2022
@quarkus-bot quarkus-bot bot added this to the 2.15 - main milestone Oct 31, 2022
@quarkus-bot quarkus-bot bot added kind/bugfix and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Oct 31, 2022
@Sgitario Sgitario deleted the 28922 branch October 31, 2022 09:58
@gsmet gsmet modified the milestones: 2.15 - main, 2.14.0.Final Oct 31, 2022
@gsmet gsmet modified the milestones: 2.14.0.Final, 2.13.4.Final Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NullPointerException in Reactive REST Client
3 participants