-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove use/mention of 'compile quarkus:dev' #28999
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2359,12 +2359,12 @@ as this will only increase the verbosity of logs in the particular test where th | |
==== Multi-module Maven Projects and the Development Mode | ||
|
||
It's not uncommon to develop an extension in a multi-module Maven project that also contains an "example" module. | ||
However, if you want to run the example in the development mode then the `-DnoDeps` system property must be used in order to exclude the local project dependencies. | ||
Otherwise, Quarkus attempts to monitor the extension classes and this may result in weird class loading issues. | ||
|
||
In multi-module Maven projects we recommend to have an explicit `compile` call to ensure compilation happens before the `quarkus:dev` goal is executed. | ||
|
||
[source,bash] | ||
---- | ||
./mvnw compile quarkus:dev -DnoDeps | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This paragraph is dedicated to multimodule projects and this is where we should mention when explicit There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. +1 on mentioning PS: Because of a error when using ECJ, I had to resort to specifying an explicit goal, so that devmojo doesn't run those executions on its own (because this is where the error happens). There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @aloubyansky I think it would probably be easier if you added an additional commit on top of @maxandersen 's changes. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @aloubyansky I've reworked this section to talk about need for explicit compile and removed noDeps mention. Should it be mentioned somewhere else or is noDeps just not relevant to use anymore ? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. By default we make as many modules in the workspace reloadable as we can handle (exceptions are extension artifacts, dependencies of extensions, parent-first artifacts and dependencies of parent-first). |
||
./mvnw compile quarkus:dev | ||
---- | ||
|
||
==== Indexer does not include your external dependency | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kind of minor but the logs below are for
mvn clean compile quarkus:dev
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated it - interesting to see how more "noisy" our output become in a year ;)