Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the Kind manifests are generated #29166

Merged
merged 1 commit into from
Nov 10, 2022
Merged

Conversation

Sgitario
Copy link
Contributor

@Sgitario Sgitario commented Nov 10, 2022

Fix #28078

Some context: the Kind manifests are only generated when adding the quarkus-kind-deployment dependency, and it should be generated when using quarkus-kind too. This is also the reason why this issue has not been spotted in the tests.

@Sgitario
Copy link
Contributor Author

cc @linvsendian

@iocanel
Copy link
Contributor

iocanel commented Nov 10, 2022

@Sgitario: It's not clear what changed with this rename.
Maybe it's just how github presents the change:

...ices/io.dekorate.ManifestGeneratorFactory
vs
...ices/io.dekorate.ManifestGeneratorFactory

@Sgitario
Copy link
Contributor Author

@Sgitario: It's not clear what changed with this rename. Maybe it's just how github presents the change:

...ices/io.dekorate.ManifestGeneratorFactory
vs
...ices/io.dekorate.ManifestGeneratorFactory

The file's view does not help. I simply moved the file io.dekorate.ManifestGeneratorFactory from quarkus-kind-deployment to quarkus-kind module.

Copy link
Contributor

@iocanel iocanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iocanel iocanel merged commit 78915da into quarkusio:main Nov 10, 2022
@quarkus-bot quarkus-bot bot added this to the 2.15 - main milestone Nov 10, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Nov 10, 2022

Milestone is already set for some of the items:

We haven't automatically updated the milestones for these items.

This message is automatically generated by a bot.

@Sgitario Sgitario deleted the 28078 branch November 10, 2022 13:58
@gsmet gsmet modified the milestones: 2.15 - main, 2.14.1.Final Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

quarkus-kind extension does not create manifests (kind.yml/.json)
4 participants