Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update latest brew openjdk package #29220

Merged
merged 1 commit into from
Nov 16, 2022
Merged

Update latest brew openjdk package #29220

merged 1 commit into from
Nov 16, 2022

Conversation

spolti
Copy link
Contributor

@spolti spolti commented Nov 11, 2022

latest openjdk is now 19:

$ brew info openjdk
==> openjdk: stable 19.0.1 (bottled) [keg-only]

@quarkus-bot
Copy link

quarkus-bot bot commented Nov 11, 2022

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)

This message is automatically generated by a bot.

@spolti spolti changed the title update latest brew openjdk package Update latest brew openjdk package Nov 11, 2022
@geoand
Copy link
Contributor

geoand commented Nov 14, 2022

I think we intentionally want Java 17 there instead of the latest JDK, but I'll let @maxandersen decide

@spolti
Copy link
Contributor Author

spolti commented Nov 14, 2022

I think we intentionally want Java 17 there instead of the latest JDK, but I'll let @maxandersen decide

I see, if that is the case it is probably better add info that using openjdk will install java19, for 17, need to use openjdk@17.

latest openjdk is now 19: 

$ brew info openjdk
==> openjdk: stable 19.0.1 (bottled) [keg-only]
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rebased and squashed the commits.

@gsmet gsmet added triage/waiting-for-ci Ready to merge when CI successfully finishes triage/backport-2.13? labels Nov 16, 2022
@gsmet gsmet merged commit 5fa2209 into quarkusio:main Nov 16, 2022
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Nov 16, 2022
@quarkus-bot quarkus-bot bot added this to the 2.15 - main milestone Nov 16, 2022
@gsmet
Copy link
Member

gsmet commented Nov 16, 2022

Thanks!

@spolti spolti deleted the patch-1 branch November 16, 2022 13:51
@gsmet gsmet modified the milestones: 2.15 - main, 2.14.2.Final Nov 21, 2022
@gsmet gsmet modified the milestones: 2.14.2.Final, 2.13.6.Final Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants