Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.13] native-image: Don't pass -H:InitialCollectionPolicy with EpsilonGC #29278

Closed
wants to merge 1 commit into from

Conversation

zakkak
Copy link
Contributor

@zakkak zakkak commented Nov 15, 2022

Closes: #29275

@zakkak zakkak requested a review from galderz November 15, 2022 13:52
@quarkus-bot
Copy link

quarkus-bot bot commented Nov 15, 2022

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)

This message is automatically generated by a bot.

@zakkak zakkak requested a review from gsmet November 15, 2022 13:52
@quarkus-bot
Copy link

quarkus-bot bot commented Nov 15, 2022

Failing Jobs - Building a2bb9b5

Status Name Step Failures Logs Raw logs
Initial JDK 11 Build Build Failures Logs Raw logs

Failures

⚙️ Initial JDK 11 Build #

- Failing: integration-tests/grpc-plain-text-mutiny 

📦 integration-tests/grpc-plain-text-mutiny

Failed to execute goal io.quarkus:quarkus-maven-plugin:999-SNAPSHOT:generate-code (default) on project quarkus-integration-test-grpc-plain-text-mutiny: Quarkus code generation phase has failed

@gsmet
Copy link
Member

gsmet commented Nov 15, 2022

I think @galderz 's idea was to backport #28295 . Unfortunately, the issue was flagged for backport instead of the PR (@galderz pointed me to the issue and I thought it was the issue, not the PR and boum).

I think we should backport #28295 for the next 2.13.z instead of this change.

Does it make sense?

@zakkak
Copy link
Contributor Author

zakkak commented Nov 16, 2022

I think we should backport #28295 for the next 2.13.z instead of this change.

Does it make sense?

Yes, either works :)

@zakkak zakkak closed this Nov 16, 2022
@quarkus-bot quarkus-bot bot added the triage/invalid This doesn't seem right label Nov 16, 2022
@galderz
Copy link
Member

galderz commented Nov 17, 2022

Agree @zakkak @geoand. It's highly unlikely someone will go and explicitly set the GC collection policy to space+time AND use epsilon GC.

@zakkak zakkak deleted the 2022-11-15-workaround-29275 branch November 17, 2022 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core triage/invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants