Apply minor improvements to CONTRIBUTING.md #29347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsmet
reviewed
Nov 18, 2022
| git clone [email protected]:quarkusio/quarkus.git | ||
| cd quarkus | ||
| export MAVEN_OPTS="-Xmx4g" | ||
| ./mvnw -Dquickly | ||
| MAVEN_OPTS="-Xmx4g" ./mvnw -Dquickly |
There was a problem hiding this comment.
We did use an export on purpose. This way you don't have to do it every time you build the tree.
But I won't fight for it if you think this is better in this context.
There was a problem hiding this comment.
But the export only survives the current terminal session, no?
I usually find that when that is done, the next time someone tries to execute the command that follows the export, it will fail and people don't know why.
On the other hand, when using the syntax I propose, you get the entire command in the shell history
gsmet
approved these changes
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.