Improve Docker detection with Unix sockets #29562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, I think I should have some time on friday to take a testround with this! |
|
@gsmet I have tested and this works perfectly fine now, and as expected! thanks! I might have small but impprtant things I would like to add to the documentation regarding this though to make life easier for next podman user. Should I fork your Docker host branch and make a pr to that ? |
|
@janderssonse I merged this one. Just make a pull request on top of |
gsmet
pushed a commit
to gsmet/quarkus
that referenced
this pull request
Dec 5, 2022
This adds further details about the fix and the discussion in quarkusio#29562. It clearifies that alias is also fine instead of podman-docker, just redirects the user to podman for install instructions ( they change over time, and more linux variant are shown there, no need duplicate and maintain), and finally, it shows a way of running podman as service without systemd (relevant on wsl up until recently for example, and users a most likely stuck with slightly older wsl's in a few places). Signed-off-by: Josef Andersson <[email protected]> (cherry picked from commit 9e85d7e)
gsmet
pushed a commit
to gsmet/quarkus
that referenced
this pull request
Dec 6, 2022
This adds further details about the fix and the discussion in quarkusio#29562. It clearifies that alias is also fine instead of podman-docker, just redirects the user to podman for install instructions ( they change over time, and more linux variant are shown there, no need duplicate and maintain), and finally, it shows a way of running podman as service without systemd (relevant on wsl up until recently for example, and users a most likely stuck with slightly older wsl's in a few places). Signed-off-by: Josef Andersson <[email protected]> (cherry picked from commit 9e85d7e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@janderssonse could you have a look if this PR fixes things for you? I'm not using Podman so I'm shooting in the dark but it should be mostly right.
https://github.com/quarkusio/quarkus/blob/main/CONTRIBUTING.md#building-main might be handy (except you need to build my PR branch, not
main).Fixes #29426