Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a way to use custom annotations in bytecode recording #29731

Merged
merged 2 commits into from
Dec 12, 2022

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Dec 7, 2022

This is a pretty advanced capability but I plan to expand the SPI in order to include other annotations as well (I am thinking about introducing an @Immutable annotation for Collections and Maps that will allow Quarkus to use Collections.emptyList() and Collections.emptyMap() when the corresponding recorded object is empty) that could be useful in RESTEasy Reactive

@geoand geoand requested a review from stuartwdouglas December 7, 2022 12:22
@quarkus-bot
Copy link

quarkus-bot bot commented Dec 7, 2022

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)

This message is automatically generated by a bot.

@gsmet gsmet changed the title ntroduce a way to use custom annotations in bytecode recording Introduce a way to use custom annotations in bytecode recording Dec 7, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Dec 7, 2022

Failing Jobs - Building 6b01e5a

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✔️ JVM Tests - JDK 17
JVM Tests - JDK 17 MacOS M1 Set up runner ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 18

@geoand
Copy link
Contributor Author

geoand commented Dec 9, 2022

@stuartwdouglas WDYT?

@geoand geoand merged commit b3b357d into quarkusio:main Dec 12, 2022
@quarkus-bot quarkus-bot bot added this to the 2.16 - main milestone Dec 12, 2022
@geoand geoand deleted the bytecode-rec-configurable-annotations branch December 12, 2022 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants