Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump smallrye-open-api from 2.3.1 to 3.1.1 #29815

Merged
merged 1 commit into from
Dec 13, 2022
Merged

Bump smallrye-open-api from 2.3.1 to 3.1.1 #29815

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion bom/application/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,12 @@
<microprofile-rest-client.version>2.0</microprofile-rest-client.version>
<microprofile-jwt.version>1.2</microprofile-jwt.version>
<microprofile-lra.version>1.0</microprofile-lra.version>
<microprofile-openapi.version>2.0.1</microprofile-openapi.version>
<smallrye-common.version>1.13.2</smallrye-common.version>
<smallrye-config.version>2.13.0</smallrye-config.version>
<smallrye-health.version>3.3.1</smallrye-health.version>
<smallrye-metrics.version>3.0.5</smallrye-metrics.version>
<smallrye-open-api.version>2.3.1</smallrye-open-api.version>
<smallrye-open-api.version>3.1.1</smallrye-open-api.version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this version will work in main with the javax packages?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's correct. The scanning is all Jandex-based and both top-level packages are scanned.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If main includes the Jakarta migration (or even MP 6), I'll need to update the version for microprofile-openapi.version

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, no, what you did is perfect.

<smallrye-graphql.version>1.9.0</smallrye-graphql.version>
<smallrye-opentracing.version>2.1.1</smallrye-opentracing.version>
<smallrye-fault-tolerance.version>5.6.0</smallrye-fault-tolerance.version>
Expand Down Expand Up @@ -4215,6 +4216,11 @@
</exclusion>
</exclusions>
</dependency>
<dependency>
<groupId>org.eclipse.microprofile.openapi</groupId>
<artifactId>microprofile-openapi-api</artifactId>
<version>${microprofile-openapi.version}</version>
</dependency>
<dependency>
<groupId>org.glassfish</groupId>
<artifactId>jakarta.el</artifactId>
Expand Down
4 changes: 2 additions & 2 deletions jakarta/rewrite.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -613,8 +613,8 @@ recipeList:
key: smallrye-metrics.version
newValue: '4.0.0'
- org.openrewrite.maven.ChangePropertyValue:
key: smallrye-open-api.version
newValue: '3.0.1'
key: microprofile-openapi.version
newValue: '3.0'
- org.openrewrite.maven.ChangePropertyValue:
key: microprofile-opentracing-api.version
newValue: '3.0'
Expand Down