Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement output-name/add-runner-suffix on Gradle #30149

Closed
wants to merge 1 commit into from
Closed

Implement output-name/add-runner-suffix on Gradle #30149

wants to merge 1 commit into from

Conversation

jacobdotcosta
Copy link
Contributor

@jacobdotcosta jacobdotcosta commented Jan 3, 2023 •
edited
Loading

NOTE: This PR has been replaced by #30286 .

Implements the quarkus.package.output-name and quarkus.package.add-runner-suffix properties on Gradle.

Closes #30101

Reproducer and fix tested on jacobdotcosta/quarkus-issue-30101 repository.

@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle labels Jan 3, 2023
@quarkus-bot

This comment was marked as resolved.

Sign in to view
@geoand geoand requested a review from glefloch January 4, 2023 09:22
@geoand geoand changed the title implement output-name/add-runner-suffix on Gradle Implement output-name/add-runner-suffix on Gradle Jan 4, 2023
@jacobdotcosta jacobdotcosta marked this pull request as ready for review January 4, 2023 14:48
@jacobdotcosta jacobdotcosta mentioned this pull request Jan 4, 2023
Closed
glefloch
glefloch requested changes Jan 4, 2023
View reviewed changes
Copy link
Member

@glefloch glefloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this work @jacobdotcosta, I left a small comment about imports but the overall looks good to me.

@quarkus-bot

This comment has been minimized.

Sign in to view
@jacobdotcosta jacobdotcosta requested a review from glefloch January 5, 2023 08:50
@geoand
Copy link
Contributor

geoand commented Jan 10, 2023

@glefloch can you have another look as it seems your comment was addressed.

Thanks

@glefloch
Copy link
Member

Looks good to me, thanks @jacobdotcosta

@glefloch glefloch added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jan 10, 2023
@geoand
Copy link
Contributor

geoand commented Jan 10, 2023

@jacobdotcosta can you please fix the conflict by rebasing onto main please?

Once that is done and CI passes, we can merge

@quarkus-bot

This comment has been minimized.

Sign in to view
@glefloch
Copy link
Member

@jacobdotcosta could you fix the conflict?

@jacobdotcosta
Copy link
Contributor Author

Yes, I'll fix it.

@quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot quarkus-bot bot added area/cli Related to quarkus cli (not maven/gradle/etc.) area/documentation area/grpc gRPC area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure area/rest labels Jan 10, 2023
geoand
geoand requested changes Jan 10, 2023
View reviewed changes
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something happened with the rebase and definitely need to be sorted out

@jacobdotcosta
Copy link
Contributor Author

Yes, I'm working on it. I think I'll create a new PR with my changes.

@jacobdotcosta jacobdotcosta marked this pull request as draft January 10, 2023 13:35
@quarkus-bot
Copy link

quarkus-bot bot commented Jan 10, 2023

Failing Jobs - Building 29d8554

Status Name Step Failures Logs Raw logs
✖ Initial JDK 11 Build Build Failures Logs Raw logs

Failures

⚙️ Initial JDK 11 Build #

- Failing: devtools/gradle/gradle-application-plugin 
! Skipped: integration-tests/gradle

📦 devtools/gradle/gradle-application-plugin

✖ Failed to execute goal net.revelc.code.formatter:formatter-maven-plugin:2.21.0:validate (default) on project io.quarkus.gradle.plugin: File '/home/runner/work/quarkus/quarkus/devtools/gradle/gradle-application-plugin/src/main/java/io/quarkus/gradle/extension/QuarkusPluginExtension.java' has not been previously formatted. Please format file (for example by invoking `mvn -f devtools/gradle/gradle-application-plugin net.revelc.code.formatter:formatter-maven-plugin:2.21.0:format`) and commit before running validation!

@jacobdotcosta jacobdotcosta mentioned this pull request Jan 10, 2023
Merged
@quarkus-bot quarkus-bot bot added triage/invalid This doesn't seem right and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand requested changes

@glefloch glefloch glefloch approved these changes

Assignees
No one assigned
Labels
area/cli Related to quarkus cli (not maven/gradle/etc.) area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/gradle Gradle area/grpc gRPC area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure area/kubernetes area/oidc area/rest area/testing area/tracing triage/invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

testNative tag ignores binary name generated by using quarkus.package.output-name/add-runner-suffix
4 participants
@jacobdotcosta @geoand @glefloch @alesj