MultiPartConfig in HTTP Vert.x extension is insufficiently documented #30214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The second sentence clarifies config property usage, thanks. I think you should not use phrase comma-separated list as strictly speaking if you use YAML you can define list without commas and you don't just write docs for application.properties; but I can see this phrase used in Quarkus multiple times, so... |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
gsmet
reviewed
Jan 6, 2023
extensions/vertx-http/runtime/src/main/java/io/quarkus/vertx/http/runtime/MultiPartConfig.java
Outdated
Show resolved
Hide resolved
Closes quarkusio#30046 Co-authored-by: Guillaume Smet <[email protected]>
cescoffier
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #30046