gRPC Dev UI - fix problems when reusing the existing HTTP server #30263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mkouba
commented
Jan 9, 2023
mkouba
commented
- i.e. when quarkus.grpc.server.use-separate-server=false is used
- fixes Dev UI for GRPC fails #30244
mkouba
commented
Jan 9, 2023
| @@ -173,6 +174,8 @@ private void buildGrpcServer(Vertx vertx, GrpcServerConfiguration configuration, | |||
| } | |||
| }); | |||
| shutdown.addShutdownTask(route::remove); // remove this route at shutdown, this should reset it | |||
|
|
|||
| initHealthStorage(); | |||
There was a problem hiding this comment.
@alesj This fixed the class loading problem - we need to initialize the GrpcHealthStorage eagerly for quarkus.grpc.server.use-separate-server=false (if needed).
There was a problem hiding this comment.
This is strange ... but ... if it's needed, then sure.
There was a problem hiding this comment.
Yes, it is. But class loading in the dev mode (+ dev ui) is tricky.
- i.e. when quarkus.grpc.server.use-separate-server=false is used - fixes quarkusio#30244
mkouba
requested review from
cescoffier and
alesj
and removed request for
cescoffier
alesj
approved these changes
Jan 10, 2023
geoand
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.