Harmonize capability constants #30983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sberyozkin I made them all the same and added a test to try to avoid bad capability strings |
sberyozkin
approved these changes
Feb 8, 2023
There was a problem hiding this comment.
Thanks @HerrDerb LGTM, I'll ask for one more review just in case
This comment has been minimized.
This comment has been minimized.
|
@HerrDerb Can you squash the last commit please before I enable the run, to avoid doing it twice, thanks |
HerrDerb
force-pushed
the
harmonize-capability-strings
branch
2 times, most recently
from
318b7bc to
d476bcf
Compare
gastaldi
approved these changes
Feb 15, 2023
This comment has been minimized.
This comment has been minimized.
HerrDerb
force-pushed
the
harmonize-capability-strings
branch
from
d476bcf to
8144118
Compare
gastaldi
requested changes
Feb 16, 2023
core/deployment/src/test/java/io/quarkus/deployment/CapabilityTest.java
Outdated
Show resolved
Hide resolved
HerrDerb
force-pushed
the
harmonize-capability-strings
branch
2 times, most recently
from
e7ea348 to
e852ecf
Compare
gastaldi
reviewed
Feb 16, 2023
core/deployment/src/test/java/io/quarkus/deployment/CapabilityTest.java
Outdated
Show resolved
Hide resolved
HerrDerb
force-pushed
the
harmonize-capability-strings
branch
from
e852ecf to
78df94f
Compare
HerrDerb
force-pushed
the
harmonize-capability-strings
branch
from
78df94f to
3d18d44
Compare
gastaldi
approved these changes
Feb 17, 2023
This comment has been minimized.
This comment has been minimized.
HerrDerb
force-pushed
the
harmonize-capability-strings
branch
from
3d18d44 to
ebcbd16
Compare
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #30953