Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hibernate reactive - remove the Mutiny.Session bean #31121

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Feb 13, 2023

Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to make sense, but I can't comment on the specifics of Reactive, so I'll let Davide/Sanne do that.

Copy link
Contributor

@DavideD DavideD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

There are several places where we could clean up the code, but it's not that important

@github-actions
Copy link

github-actions bot commented Feb 13, 2023

🙈 The PR is closed and the preview is expired.

@mkouba
Copy link
Contributor Author

mkouba commented Feb 13, 2023

There are several places where we could clean up the code, but it's not that important

For sure we could. I've just tried to adapt the original code...

@quarkus-bot

This comment has been minimized.

@mkouba
Copy link
Contributor Author

mkouba commented Feb 13, 2023

For the record - I've removed the producer method because there's no easy way to deprecate a bean. I mean we could detect all Mutiny.Session injection points and log a warning during build but a user gets no warning in the IDE etc. So I think it's better to remove the bean completely.

@mkouba
Copy link
Contributor Author

mkouba commented Feb 13, 2023

Note to myself - if this PR is merged then add an appropriate section to the migration guide.

@mkouba mkouba requested a review from DavideD February 13, 2023 15:06
@quarkus-bot
Copy link

quarkus-bot bot commented Feb 13, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@Sanne
Copy link
Member

Sanne commented Feb 13, 2023

For the record - I've removed the producer method because there's no easy way to deprecate a bean. I mean we could detect all Mutiny.Session injection points and log a warning during build but a user gets no warning in the IDE etc. So I think it's better to remove the bean completely.

Makes sense! Many thanks

Copy link
Member

@Sanne Sanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to remove this!

@Sanne Sanne merged commit f9dc74f into quarkusio:main Feb 13, 2023
@quarkus-bot quarkus-bot bot added this to the 3.0 - main milestone Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hibernate reactive - deprecate the usage of injected Mutiny.Session
4 participants