-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hibernate reactive - remove the Mutiny.Session bean #31121
Conversation
mkouba
commented
Feb 13, 2023
- resolves Hibernate reactive - deprecate the usage of injected Mutiny.Session #30717
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to make sense, but I can't comment on the specifics of Reactive, so I'll let Davide/Sanne do that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There are several places where we could clean up the code, but it's not that important
...src/main/java/io/quarkus/it/hibernate/reactive/postgresql/HibernateReactiveTestEndpoint.java
Outdated
Show resolved
Hide resolved
...n/java/io/quarkus/it/hibernate/reactive/db2/HibernateReactiveDB2AlternativeTestEndpoint.java
Outdated
Show resolved
Hide resolved
🙈 The PR is closed and the preview is expired. |
For sure we could. I've just tried to adapt the original code... |
This comment has been minimized.
This comment has been minimized.
For the record - I've removed the producer method because there's no easy way to deprecate a bean. I mean we could detect all |
Note to myself - if this PR is merged then add an appropriate section to the migration guide. |
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
Makes sense! Many thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to remove this!