Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the Micrometer card for the new dev ui #31426

Merged
merged 1 commit into from
Mar 1, 2023

Conversation

cescoffier
Copy link
Member

No description provided.

@quarkus-bot
Copy link

quarkus-bot bot commented Feb 26, 2023

/cc @brunobat (micrometer), @ebullient (micrometer)

@cescoffier cescoffier mentioned this pull request Feb 26, 2023
56 tasks
@quarkus-bot

This comment has been minimized.

@gsmet gsmet requested a review from phillip-kruger February 27, 2023 12:43
Copy link
Member

@phillip-kruger phillip-kruger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I can not comment on Erin's review, so once she is happy I think we can merge. We can maybe (later) add a Prometheus markup to the external Page

Only link the prometheus and json metrics.
@quarkus-bot
Copy link

quarkus-bot bot commented Feb 28, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@gsmet
Copy link
Member

gsmet commented Mar 1, 2023

@ebullient I let you merge it if you are happy.

@ebullient ebullient merged commit 78b1a19 into quarkusio:main Mar 1, 2023
@quarkus-bot quarkus-bot bot added this to the 3.0 - main milestone Mar 1, 2023
@ebullient ebullient deleted the devui-micrometer branch March 1, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants