Make Scheduler not log in Dev UI log #31601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Phillip Kruger <[email protected]>
Failing Jobs - Building 3008002
Full information is available in the Build summary check run. Failures⚙️ Gradle Tests - JDK 11 #- Failing: integration-tests/gradle
📦 integration-tests/gradle✖ |
cescoffier
approved these changes
Mar 7, 2023
mkouba
reviewed
Mar 9, 2023
| @@ -7,8 +7,8 @@ import { LogController } from 'log-controller'; | |||
| */ | |||
| export class QwcSchedulerLog extends LitElement { | |||
|
|
|||
| jsonRpc = new JsonRpc("Scheduler"); | |||
| logControl = new LogController(this, "qwc-scheduler-log"); | |||
| jsonRpc = new JsonRpc("Scheduler", false); | |||
There was a problem hiding this comment.
I wonder if it would make sense to also provide a finer grained option?
Also the logging is very useful during dev UI development/for debugging. So it would be nice to have an easy way to enable the logging for an extension. But I have no idea how this could work 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR make the scheduler log not repeat in Dev UI log (sorry @mkouba I forgot to get back to you w.r.t this)
It also: