RuntimeUpdatesProcessor now supports hot replacement problems #31645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
geoand
approved these changes
Mar 8, 2023
|
The test failure doesn't seem related… |
Failing Jobs - Building 25bc923
Full information is available in the Build summary check run. Failures⚙️ Gradle Tests - JDK 11 #- Failing: integration-tests/gradle
📦 integration-tests/gradle✖ |
|
Don't worry about the Gradle tests, they are not terribly reliable |
|
In this case, let's merge and get rid of this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31013
This allows participants that implement
HotReplacementSetupto throw problems which will:ErrorPageGeneratorsprocess to be displayed in the web UII'm unsure about the fact that I only stop and map the first error from the list of
HotReplacementSetupproviders. But ATM we don't have support forErrorPageGeneratorsfor more than one kind of exception at a time.