Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose the new dev ui under /q/dev The old dev ui is under /q/devui-v1 #31973

Closed
wants to merge 1 commit into from

Conversation

cescoffier
Copy link
Member

The old dev ui is under /q/devui-v1.

The old dev ui is under /q/devui-v1.
@quarkus-bot quarkus-bot bot added area/arc Issue related to ARC (dependency injection) area/cache area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/fault-tolerance area/flyway area/grpc gRPC area/maven area/platform Issues related to definition and interaction with Quarkus Platform area/reactive-messaging area/rest area/scheduler area/smallrye area/testing area/vertx labels Mar 20, 2023
@github-actions
Copy link

github-actions bot commented Mar 20, 2023

🙈 The PR is closed and the preview is expired.

@gastaldi
Copy link
Contributor

How about naming it /q/dev/v1/? That would make it simpler to type ;)

@quarkus-bot
Copy link

quarkus-bot bot commented Mar 20, 2023

Failing Jobs - Building 268d619

Status Name Step Failures Logs Raw logs
JVM Tests - JDK 11 Build Failures Logs Raw logs
JVM Tests - JDK 17 Build Failures Logs Raw logs
JVM Tests - JDK 17 Windows Build Failures Logs Raw logs
JVM Tests - JDK 19 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: extensions/hibernate-orm/deployment extensions/qute/deployment extensions/scheduler/deployment and 1 more
! Skipped: devtools/cli devtools/gradle/gradle-application-plugin devtools/gradle/gradle-extension-plugin and 100 more

📦 extensions/hibernate-orm/deployment

io.quarkus.hibernate.orm.HibernateSchemaRecreateDevConsoleTestCase.testCleanDatabase line 27 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <303> but was <200>.

📦 extensions/qute/deployment

io.quarkus.qute.deployment.devconsole.DevConsolePreviewTest.testLoopPreview line 26 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Response body doesn't match expectation.

📦 extensions/scheduler/deployment

io.quarkus.scheduler.test.devconsole.DevConsoleRunScheduledTaskBodyHandlerTest.testInvokeScheduledTask line 30 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <303> but was <200>.

io.quarkus.scheduler.test.devconsole.DevConsoleRunScheduledTaskTest.testInvokeScheduledTask line 27 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <303> but was <200>.

📦 independent-projects/tools/devtools-testing

io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartGenerationTest.verifyIndexExtensionList(TestInfo) line 97 - More details - Source on GitHub

java.lang.AssertionError: 
[Snapshot is not matching (use -Dsnap to update it automatically): QuarkusCodestartGenerationTest/verifyIndexExtensionList/src_main_resources_META-INF_resources_index.html] 
Path:

io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartGenerationTest.generateRESTEasyJavaCustom(TestInfo) line 83 - More details - Source on GitHub

java.lang.AssertionError: 
[Snapshot is not matching (use -Dsnap to update it automatically): QuarkusCodestartGenerationTest/generateRESTEasyJavaCustom/src_main_resources_META-INF_resources_index.html] 
Path:

⚙️ JVM Tests - JDK 17 #

- Failing: extensions/hibernate-orm/deployment extensions/qute/deployment extensions/scheduler/deployment and 1 more
! Skipped: devtools/cli devtools/gradle/gradle-application-plugin devtools/gradle/gradle-extension-plugin and 101 more

📦 extensions/hibernate-orm/deployment

io.quarkus.hibernate.orm.HibernateSchemaRecreateDevConsoleTestCase.testCleanDatabase line 27 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <303> but was <200>.

📦 extensions/qute/deployment

io.quarkus.qute.deployment.devconsole.DevConsolePreviewTest.testLoopPreview line 26 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Response body doesn't match expectation.

📦 extensions/scheduler/deployment

io.quarkus.scheduler.test.devconsole.DevConsoleRunScheduledTaskBodyHandlerTest.testInvokeScheduledTask line 30 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <303> but was <200>.

io.quarkus.scheduler.test.devconsole.DevConsoleRunScheduledTaskTest.testInvokeScheduledTask line 27 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <303> but was <200>.

📦 independent-projects/tools/devtools-testing

io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartGenerationTest.verifyIndexExtensionList(TestInfo) line 97 - More details - Source on GitHub

java.lang.AssertionError: 
[Snapshot is not matching (use -Dsnap to update it automatically): QuarkusCodestartGenerationTest/verifyIndexExtensionList/src_main_resources_META-INF_resources_index.html] 
Path:

io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartGenerationTest.generateRESTEasyJavaCustom(TestInfo) line 83 - More details - Source on GitHub

java.lang.AssertionError: 
[Snapshot is not matching (use -Dsnap to update it automatically): QuarkusCodestartGenerationTest/generateRESTEasyJavaCustom/src_main_resources_META-INF_resources_index.html] 
Path:

⚙️ JVM Tests - JDK 17 Windows #

- Failing: extensions/grpc/deployment extensions/hibernate-orm/deployment extensions/qute/deployment and 2 more
! Skipped: devtools/cli devtools/gradle/gradle-application-plugin devtools/gradle/gradle-extension-plugin and 189 more

📦 extensions/grpc/deployment

io.quarkus.grpc.server.devmode.GrpcDevModeTest.testEchoStreamReload line 118 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: io.quarkus.grpc.server.devmode.GrpcDevModeTest expected a collection containing "newecho::foo" but was empty within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AbstractHamcrestCondition.await(AbstractHamcrestCondition.java:86)

📦 extensions/hibernate-orm/deployment

io.quarkus.hibernate.orm.HibernateSchemaRecreateDevConsoleTestCase.testCleanDatabase line 27 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <303> but was <200>.

📦 extensions/qute/deployment

io.quarkus.qute.deployment.devconsole.DevConsolePreviewTest.testLoopPreview line 26 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Response body doesn't match expectation.

📦 extensions/resteasy-classic/rest-client/runtime

io.quarkus.restclient.runtime.RestClientBaseTest. - More details - Source on GitHub

java.io.IOException: Failed to delete temp directory D:\a\quarkus\quarkus\extensions\resteasy-classic\rest-client\runtime\target\junit9838351431714348550. The following paths could not be deleted (see suppressed exceptions for details): 
	at org.junit.jupiter.engine.extension.TempDirectory$CloseablePath.createIOExceptionWithAttachedFailures(TempDirectory.java:350)
	at org.junit.jupiter.engine.extension.TempDirectory$CloseablePath.close(TempDirectory.java:251)

📦 independent-projects/tools/devtools-testing

io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartGenerationTest.verifyIndexExtensionList(TestInfo) line 97 - More details - Source on GitHub

java.lang.AssertionError: 
[Snapshot is not matching (use -Dsnap to update it automatically): QuarkusCodestartGenerationTest/verifyIndexExtensionList/src_main_resources_META-INF_resources_index.html] 
Path:

io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartGenerationTest.generateRESTEasyJavaCustom(TestInfo) line 83 - More details - Source on GitHub

java.lang.AssertionError: 
[Snapshot is not matching (use -Dsnap to update it automatically): QuarkusCodestartGenerationTest/generateRESTEasyJavaCustom/src_main_resources_META-INF_resources_index.html] 
Path:

⚙️ JVM Tests - JDK 19 #

- Failing: extensions/hibernate-orm/deployment extensions/qute/deployment extensions/scheduler/deployment and 1 more
! Skipped: devtools/cli devtools/gradle/gradle-application-plugin devtools/gradle/gradle-extension-plugin and 101 more

📦 extensions/hibernate-orm/deployment

io.quarkus.hibernate.orm.HibernateSchemaRecreateDevConsoleTestCase.testCleanDatabase line 27 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <303> but was <200>.

📦 extensions/qute/deployment

io.quarkus.qute.deployment.devconsole.DevConsolePreviewTest.testLoopPreview line 26 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Response body doesn't match expectation.

📦 extensions/scheduler/deployment

io.quarkus.scheduler.test.devconsole.DevConsoleRunScheduledTaskBodyHandlerTest.testInvokeScheduledTask line 30 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <303> but was <200>.

io.quarkus.scheduler.test.devconsole.DevConsoleRunScheduledTaskTest.testInvokeScheduledTask line 27 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <303> but was <200>.

📦 independent-projects/tools/devtools-testing

io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartGenerationTest.verifyIndexExtensionList(TestInfo) line 97 - More details - Source on GitHub

java.lang.AssertionError: 
[Snapshot is not matching (use -Dsnap to update it automatically): QuarkusCodestartGenerationTest/verifyIndexExtensionList/src_main_resources_META-INF_resources_index.html] 
Path:

io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartGenerationTest.generateRESTEasyJavaCustom(TestInfo) line 83 - More details - Source on GitHub

java.lang.AssertionError: 
[Snapshot is not matching (use -Dsnap to update it automatically): QuarkusCodestartGenerationTest/generateRESTEasyJavaCustom/src_main_resources_META-INF_resources_index.html] 
Path:

@phillip-kruger
Copy link
Member

Hi @cescoffier . When we started the new Dev UI we intentionally made the url /q/dev-ui to be the same as other UI (swagger-ui, graphql-ui, health-ui) and the plan was to, when we migrate, route /q/dev to /q/dev-ui. So dev will still work, but redirect to dev-ui. That will also make this change much smaller ? w.d.y.t ?

@cescoffier
Copy link
Member Author

I can try to setup the redirection. The difficulty is mostly move the old one, as their is lots of substring / startWith and regexp. Finding something that does not collide is not simple (and seems that even the current one does not work). I will have another look this week (but cannot tell you when exactly)

@phillip-kruger
Copy link
Member

Thanks @cescoffier !

@cescoffier
Copy link
Member Author

Superseded by #32151.

@cescoffier cescoffier closed this Mar 27, 2023
@quarkus-bot quarkus-bot bot added the triage/invalid This doesn't seem right label Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/arc Issue related to ARC (dependency injection) area/cache area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/fault-tolerance area/flyway area/grpc gRPC area/maven area/platform Issues related to definition and interaction with Quarkus Platform area/reactive-messaging area/rest area/scheduler area/smallrye area/testing area/vertx triage/invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants