Reduce LauncherUtil check-interval from 500 to 50 ms #33066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
snazy
force-pushed
the
launcher-check-interval-50
branch
from
d1817ec to
e587bf3
Compare
This comment has been minimized.
This comment has been minimized.
snazy
force-pushed
the
launcher-check-interval-50
branch
from
e587bf3 to
06bd854
Compare
This comment has been minimized.
This comment has been minimized.
gastaldi
force-pushed
the
launcher-check-interval-50
branch
from
06bd854 to
9a8774d
Compare
This comment has been minimized.
This comment has been minimized.
snazy
force-pushed
the
launcher-check-interval-50
branch
from
9a8774d to
6f6063a
Compare
This comment has been minimized.
This comment has been minimized.
500ms feels a bit long and can cause some wasted time during test runs, especially on beefier machines. It feels safe to reduce this to 50ms, which should work even on tiny CI runner instances, as it's mostly sleep time + a cheap-ish "has more data" check against the log file.
gsmet
force-pushed
the
launcher-check-interval-50
branch
from
6f6063a to
935cc3a
Compare
gsmet
approved these changes
Jun 6, 2023
gsmet
added
the
triage/waiting-for-ci
Failing Jobs - Building 935cc3a
Full information is available in the Build summary check run. Failures⚙️ Native Tests - Amazon #- Failing: integration-tests/amazon-lambda integration-tests/amazon-lambda-http
📦 integration-tests/amazon-lambda✖ 📦 integration-tests/amazon-lambda-http✖ |
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
500ms feels a bit long and can cause some wasted time during test runs, especially on beefier machines. It feels safe to reduce this to 50ms, which should work even on tiny CI runner instances, as it's mostly sleep time + a cheap-ish "has more data" check against the log file.