Allow serializing complex objects in JobDataMaps when using Quartz extension #33534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
machi1990
changed the title
machi1990
commented
May 22, 2023
extensions/quartz/runtime/src/main/java/io/quarkus/quartz/runtime/QuartzBuildTimeConfig.java
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
mkouba
reviewed
May 23, 2023
extensions/quartz/runtime/src/main/java/io/quarkus/quartz/runtime/QuartzBuildTimeConfig.java
Outdated
Show resolved
Hide resolved
mkouba
reviewed
May 23, 2023
integration-tests/quartz/src/test/java/io/quarkus/it/quartz/QuartzTestCase.java
Outdated
Show resolved
Hide resolved
mkouba
reviewed
May 23, 2023
extensions/quartz/runtime/src/main/java/io/quarkus/quartz/runtime/jdbc/DBDelegateUtils.java
Outdated
Show resolved
Hide resolved
machi1990
force-pushed
the
quartz/allow-serializing-complex-object-in-job-data
branch
from
fbbdac5 to
36218cf
Compare
mkouba
added
the
triage/waiting-for-ci
machi1990
force-pushed
the
quartz/allow-serializing-complex-object-in-job-data
branch
from
36218cf to
6107453
Compare
|
Thanks for the review @mkouba |
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
quarkus-bot
bot
added
kind/enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30834