Upgrade Kotlin to 1.8.22 #33972
Merged
Upgrade Kotlin to 1.8.22 #33972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/arc
geoand
approved these changes
Jun 12, 2023
This comment has been minimized.
This comment has been minimized.
gsmet
commented
Jun 13, 2023
Comment on lines
+4
to
5
| # updating Kotlin here makes QuarkusPluginTest > shouldNotFailOnProjectDependenciesWithoutMain(Path) fail | ||
| kotlin = "1.8.10" |
There was a problem hiding this comment.
@snazy would you have an idea as to why we cannot upgrade Kotlin here?
We end up with:
Cannot access 'org.jetbrains.kotlin.gradle.plugin.KotlinTargetsContainerWithPresets' which is a supertype of 'org.jetbrains.kotlin.gradle.dsl.KotlinTargetContainerWithPresetFunctions'. Check your module classpath for missing or conflicting dependencies
I thought that maybe we had conflicting Kotlin versions but I couldn't find anything tied to 1.8.10. Or maybe Gradle comes with Kotlin 1.8.10?
There was a problem hiding this comment.
Yea, I think that Gradle comes with that version. It should however only affect Quarkus' Gradle plugin itself, not the application code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.