Fix broken links in the RestEasy Reactive guide #35781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoand
reviewed
Sep 6, 2023
| :resteasy-reactive-common-api: https://javadoc.io/doc/io.quarkus.resteasy.reactive/resteasy-reactive-common/{quarkus-version} | ||
| :jsonpapi: https://javadoc.io/doc/jakarta.json/jakarta.json-api/2.1.2/jakarta.json | ||
| :injectapi: https://javadoc.io/static/jakarta.inject/jakarta.inject-api/2.0.1/jakarta.inject | ||
| :vertxapi: https://javadoc.io/static/io.vertx/vertx-core/4.4.5 |
There was a problem hiding this comment.
Hm... Hardcoding the Vert.x version doesn't sounds to great, right?
There was a problem hiding this comment.
How is this handled in the Vert.x guide?
There was a problem hiding this comment.
I know, but given that the API is unlikely to change (and I was a bit lazy to deal with version filtering) I thought it would be okay for now
There was a problem hiding this comment.
How is this handled in the Vert.x guide?
The Vert.x Javadoc is rendered using frames by default, so I linked to the non-framed version. I didn't find any external link to the Vert.x Javadocs in the Vert.x guide
geoand
approved these changes
Sep 6, 2023
|
🙈 The PR is closed and the preview is expired. |
gastaldi
force-pushed
the
fix_reactive_links
branch
2 times, most recently
from
384bd8d to
be1851b
Compare
gastaldi
force-pushed
the
fix_reactive_links
branch
from
be1851b to
0074355
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.