Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly add @CheckReturnValue #36038

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Properly add @CheckReturnValue #36038

merged 1 commit into from
Sep 21, 2023

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Sep 20, 2023 •
edited
Loading

  • We don't add it if it's already there
  • We don't run the transformation twice

Fixes: #35715

Based on the analysis by @jponge

@geoand geoand mentioned this pull request Sep 20, 2023
Closed
@geoand geoand requested a review from yrodiere September 20, 2023 13:31
yrodiere
yrodiere approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what this annotation is for even after looking it up, but at least the patch does seem to make sense. Thanks.

@yrodiere yrodiere added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 20, 2023
@jponge
Copy link
Member

jponge commented Sep 20, 2023 •
edited
Loading

I'm not sure what this annotation is for even after looking it up, but at least the patch does seem to make sense. Thanks.

It's used to let IDEs know that a returned object should be used.

For instance if you have call uni.map(...) but never use (e.g. subscribe to) the Uni returned by .map then the IDE will let you know that there's possibly something wrong

@geoand @gsmet
Properly add @CheckReturnValue
88f0f1c 
* We don't add it if it's already there
* We don't run the transformation twice

Fixes: quarkusio#35715
@quarkus-bot
Copy link

quarkus-bot bot commented Sep 21, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@geoand geoand merged commit 26d7a56 into quarkusio:main Sep 21, 2023
@geoand geoand deleted the #35715 branch September 21, 2023 08:10
@quarkus-bot quarkus-bot bot added this to the 3.5 - main milestone Sep 21, 2023
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 21, 2023
@gsmet gsmet modified the milestones: 3.5 - main, 3.4.2 Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yrodiere yrodiere yrodiere approved these changes

Assignees
No one assigned
Labels
area/panache kind/bugfix
Projects
None yet
Milestone
3.4.2
Development

Successfully merging this pull request may close these issues.

Duplicate annotation for class: interface io.smallrye.common.annotation.CheckReturnValue
4 participants
@geoand @jponge @yrodiere @gsmet