OpenAPI different default content type for pojo return and primitives #36198
Conversation
quarkus-bot
bot
added
area/dependencies
phillip-kruger
force-pushed
the
openapi-default-content-type
branch
2 times, most recently
from
91257a7 to
efa0338
Compare
phillip-kruger
added
the
triage/waiting-for-ci
This comment has been minimized.
This comment has been minimized.
phillip-kruger
force-pushed
the
openapi-default-content-type
branch
from
efa0338 to
5ec36ca
Compare
Signed-off-by: Phillip Kruger <[email protected]>
phillip-kruger
force-pushed
the
openapi-default-content-type
branch
from
5ec36ca to
29f26d3
Compare
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
quarkus-bot
bot
removed
the
triage/waiting-for-ci
| System.setProperty(io.smallrye.openapi.api.constants.OpenApiConstants.DEFAULT_PRODUCES_PRIMITIVES, "plain/text"); | ||
| System.setProperty(io.smallrye.openapi.api.constants.OpenApiConstants.DEFAULT_CONSUMES_PRIMITIVES, "plain/text"); |
|
@phillip-kruger also shouldn't this have breaking change or noteworthy label as this changes the default? |
| @@ -216,7 +215,9 @@ SyntheticBeanBuildItem initBasicAuth( | |||
| && !buildTimeConfig.auth.basic.orElse(false)) { | |||
| //if not explicitly enabled we make this a default bean, so it is the fallback if nothing else is defined | |||
| configurator.defaultBean(); | |||
| securityInformationProducer.produce(SecurityInformationBuildItem.BASIC()); | |||
| if (buildTimeConfig.auth.basic.isPresent() && buildTimeConfig.auth.basic.get()) { | |||
There was a problem hiding this comment.
line 215 !buildTimeConfig.auth.basic.orElse(false) means that
quarkus.http.auth.basic is missing => inside IF body
quarkus.http.auth.basic=false => inside IF body
quarkus.http.auth.basic=true => don't go in
while line 218 says
buildTimeConfig.auth.basic.isPresent() => quarkus.http.auth.basic=false || quarkus.http.auth.basic=true
buildTimeConfig.auth.basic.get() => quarkus.http.auth.basic=true
so in order to have produced BASIC here it means that quarkus.http.auth.basic must be both true and false
@phillip-kruger I don't know what was intention of this condition, can you please fix it? Thank you
Fix #34700
Draft for now until OpenAPI release