Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GraalVM.Version#getVersionAsString #36260

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Fix GraalVM.Version#getVersionAsString #36260

merged 1 commit into from
Oct 3, 2023

Conversation

zakkak
Copy link
Contributor

@zakkak zakkak commented Oct 3, 2023

  • Fix joining of version digits
  • Don't append "null" suffix

Follow-up to #36037

@zakkak
Fix GraalVM.Version#getVersionAsString
2e2c60d 
- Fix joining of version digits
- Don't append "null" suffix

Follow-up to quarkusio#36037
@quarkus-bot quarkus-bot bot added the area/core label Oct 3, 2023
@zakkak zakkak requested a review from gastaldi October 3, 2023 09:58
@zakkak zakkak added this to the 3.5 - main milestone Oct 3, 2023
@zakkak zakkak added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 3, 2023
@zakkak zakkak mentioned this pull request Oct 3, 2023
Merged
jerboaa
jerboaa approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@quarkus-bot
Copy link

quarkus-bot bot commented Oct 3, 2023

Failing Jobs - Building 2e2c60d

Status Name Step Failures Logs Raw logs Build scan
✔️ JVM Tests - JDK 11
✔️ JVM Tests - JDK 17
✖ JVM Tests - JDK 20 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 20 #

- Failing: integration-tests/rest-client-reactive

📦 integration-tests/rest-client-reactive

✖ io.quarkus.it.rest.client.BasicTest.shouldRetryOnFailure line 74 - More details - Source on GitHub

java.net.SocketTimeoutException: Read timed out
	at java.base/sun.nio.ch.NioSocketImpl.timedRead(NioSocketImpl.java:278)
	at java.base/sun.nio.ch.NioSocketImpl.implRead(NioSocketImpl.java:304)

@gsmet gsmet merged commit 9b886e4 into quarkusio:main Oct 3, 2023
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 3, 2023
@zakkak zakkak deleted the 2023-10-02-cleanup-graalvm-versions-code branch October 4, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastaldi gastaldi gastaldi approved these changes

@jerboaa jerboaa jerboaa approved these changes

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
area/core
Projects
None yet
Milestone
3.5.0.CR1
Development

Successfully merging this pull request may close these issues.
4 participants
@zakkak @gastaldi @jerboaa @gsmet