Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update javadocs for various build items #36426

Merged

Conversation

nderwin
Copy link
Contributor

@nderwin nderwin commented Oct 11, 2023

Updates for consistency, verb tense, spelling, and grammar that I noticed while working through the "Building my first extension" guide.

Signed-off-by:Nathan Erwin [email protected]

Updates for consistency, verb tense, spelling, and grammar that I noticed while working through the "Building my first extension" guide.

Signed-off-by:Nathan Erwin <[email protected]>
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@quarkus-bot
Copy link

quarkus-bot bot commented Oct 16, 2023

Failing Jobs - Building 9713f7f

Status Name Step Failures Logs Raw logs Build scan
JVM Tests - JDK 11 Build ⚠️ Check → Logs Raw logs
JVM Tests - JDK 17 Build Failures Logs Raw logs
JVM Tests - JDK 20 Build Failures Logs Raw logs
✔️ Maven Tests - JDK 11
Maven Tests - JDK 11 Windows Build Failures Logs Raw logs
Native Tests - Data7 Build Failures Logs Raw logs
Native Tests - Windows - RESTEasy Jackson Setup GraalVM ⚠️ Check → Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 17 #

- Failing: extensions/oidc-client-graphql/deployment 

📦 extensions/oidc-client-graphql/deployment

io.quarkus.oidc.client.graphql.GraphQLClientUsingOidcClientTest.dynamicClientWithDefault - More details - Source on GitHub

io.quarkus.dev.appstate.ApplicationStartException: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.dev.appstate.ApplicationStateNotification.waitForApplicationStart(ApplicationStateNotification.java:58)
	at io.quarkus.runner.bootstrap.StartupActionImpl.runMainClass(StartupActionImpl.java:132)

⚙️ JVM Tests - JDK 20 #

- Failing: extensions/oidc-client-graphql/deployment integration-tests/virtual-threads/jms-virtual-threads 

📦 extensions/oidc-client-graphql/deployment

io.quarkus.oidc.client.graphql.GraphQLClientUsingOidcClientTest.dynamicClientWithDefault - More details - Source on GitHub

io.quarkus.dev.appstate.ApplicationStartException: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.dev.appstate.ApplicationStateNotification.waitForApplicationStart(ApplicationStateNotification.java:58)
	at io.quarkus.runner.bootstrap.StartupActionImpl.runMainClass(StartupActionImpl.java:132)

📦 integration-tests/virtual-threads/jms-virtual-threads

io.quarkus.it.vthreads.jms.VirtualThreadTest.testAlert - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.artemis.core.deployment.DevServicesArtemisProcessor#startArtemisDevService threw an exception: org.testcontainers.containers.ContainerFetchException: Can't get Docker image: RemoteDockerImage(imageName=quay.io/artemiscloud/activemq-artemis-broker:1.0.18, imagePullPolicy=DefaultPullPolicy(), imageNameSubstitutor=org.testcontainers.utility.ImageNameSubstitutor$LogWrappedImageNameSubstitutor@210db112)

⚙️ Maven Tests - JDK 11 Windows #

- Failing: integration-tests/maven 

📦 integration-tests/maven

io.quarkus.maven.it.DevMojoIT.testExternalReloadableArtifacts line 1448 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.DevMojoIT was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

io.quarkus.maven.it.JarRunnerIT.testNonAsciiDir line 70 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

io.quarkus.maven.it.DevMojoIT.testExternalReloadableArtifacts line 1448 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.DevMojoIT was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

io.quarkus.maven.it.JarRunnerIT.testNonAsciiDir line 70 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

⚙️ Native Tests - Data7 #

- Failing: integration-tests/hibernate-reactive-mariadb 

📦 integration-tests/hibernate-reactive-mariadb

Failed to execute goal io.fabric8:docker-maven-plugin:0.43.4:build (docker-start) on project quarkus-integration-test-hibernate-reactive-mariadb: Unable to pull 'docker.io/mariadb:10.11' from registry 'docker.io' : {"message":"Head \"https://registry-1.docker.io/v2/library/mariadb/manifests/10.11\": error parsing HTTP 429 response body: invalid character 'S' looking for beginning of value: \"Server capacity exceeded.\\n\""} (Internal Server Error: 500)

@gsmet gsmet merged commit 1b3720b into quarkusio:main Oct 17, 2023
@quarkus-bot quarkus-bot bot added this to the 3.6 - main milestone Oct 17, 2023
@nderwin nderwin deleted the feature/update-core-deployment-javadocs branch October 17, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants