Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinispan client ref guide update with sni host validation #36519

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

karesti
Copy link
Member

@karesti karesti commented Oct 17, 2023

Added some explanations to Infinispan SNI host name validation

Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for quick response and documenting this. You will need someone else to review though.

----
quarkus.infinispan-client.ssl-host-name-validation=false <1>
----

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one extra line, but I can't see documentation preview, so maybe it won't cause any issues. It's fine if you are sure it will convert correctly.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC, it renders OK but I force pushed the change to be on the safe side as the doc is pushed to multiple inconsistent tools downstream.

@gsmet gsmet force-pushed the infinispan-client-ref branch from e9a1a60 to 2e7eeaa Compare October 17, 2023 15:40
@github-actions
Copy link

github-actions bot commented Oct 17, 2023

🙈 The PR is closed and the preview is expired.

@gsmet gsmet merged commit ef2a86e into quarkusio:main Oct 18, 2023
@quarkus-bot quarkus-bot bot added this to the 3.6 - main milestone Oct 18, 2023
@karesti karesti deleted the infinispan-client-ref branch October 18, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants